Uploaded image for project: 'Qpid'
  1. Qpid
  2. QPID-5790

Python client should prefer select() to poll() if patched by eventlet

    Details

    • Type: Improvement
    • Status: Closed
    • Priority: Major
    • Resolution: Fixed
    • Affects Version/s: 0.28
    • Fix Version/s: 0.30
    • Component/s: Python Client
    • Labels:
      None

      Description

      QPID-5588 avoids a limitation on the use of file descriptors > 1024 in value by using poll() instead of select() when poll is available. However, the eventlet greenthreads library does not work with poll, only select. Clients that use eventlet greenthreads will fail to operate properly with the qpid python client.

      As the fix to QPID-5588 dynamically chooses either select or poll based on poll's availability, it should be possible to enhance this check to also determine if the select() method has been provided by greenthreads, and, if so, use select() instead of poll(). This would allow greenthreaded clients to work properly.

      for more information regarding greenthreads, see http://eventlet.net/

        Activity

        Hide
        jira-bot ASF subversion and git services added a comment -

        Commit 1598586 from Ken Giusti in branch 'qpid/trunk'
        [ https://svn.apache.org/r1598586 ]

        QPID-5790: avoid use of poll if select is monkey-patched by Eventlet/Greenthreads

        Show
        jira-bot ASF subversion and git services added a comment - Commit 1598586 from Ken Giusti in branch 'qpid/trunk' [ https://svn.apache.org/r1598586 ] QPID-5790 : avoid use of poll if select is monkey-patched by Eventlet/Greenthreads
        Hide
        justi9 Justin Ross added a comment -

        Ken Giusti, is this resolved?

        Show
        justi9 Justin Ross added a comment - Ken Giusti , is this resolved?
        Hide
        kgiusti Ken Giusti added a comment -

        Yeah, sorry - slipped my mind.

        Show
        kgiusti Ken Giusti added a comment - Yeah, sorry - slipped my mind.

          People

          • Assignee:
            kgiusti Ken Giusti
            Reporter:
            kgiusti Ken Giusti
          • Votes:
            0 Vote for this issue
            Watchers:
            3 Start watching this issue

            Dates

            • Created:
              Updated:
              Resolved:

              Development