[QPID-5300] [AMQP 1.0] Some ACL errors are returned as internal error instead of unauthorized error

• Type: Bug
• Status: Closed
• Priority: Major
• Resolution: Fixed
• Affects Version/s: 0.25
• Fix Version/s: 0.25
• Component/s: C++ Broker
• Assignee: Gordon Sim
• Reporter: Jakub Scholz
• Created: 06/Nov/13 16:21
• Updated: 19/Feb/14 11:30
• Resolved: 08/Nov/13 14:12

Description

It seems when some ACL errors occur, the C++ broker is sometimes using the AMQP 1.0 error code unauthorized-access and sometimes internal-error. For example the "ACL denied queue access" error is amqp:unauthorized-access:

[0x24ca9d0:0] <- @detach [handle=0, closed=true, error=@error {condition=:"amqp:unauthorized-access", description="ACL denied queue access request from ABCFR_ABCFRALMMACC1@QPID0000 (/home/jakub/qpid/qpid-trunk/cpp/src/qpid/broker/amqp/Authorise.cpp:72)"]]

But "ACL denied queue create access" is amqp:internal-error:

[0x1d14b10:0] <- @detach [handle=1, closed=true, error=@error [condition=:"amqp:internal-error", description="unauthorized-access: ACL denied queue create request from ABCFR_ABCFRALMMACC1@QPID0000 (/home/jakub/qpid/qpid-trunk/cpp/src/qpid/broker/Broker.cpp:1295)"]]

I would expect that all ACL errors should be returned as amqp:unauthorized-access.