Qpid
  1. Qpid
  2. QPID-5061

[C++ broker] The qpidd broker crashes when two links are created with the same name

    Details

    • Type: Bug Bug
    • Status: Closed
    • Priority: Major Major
    • Resolution: Fixed
    • Affects Version/s: 0.24
    • Fix Version/s: 0.24
    • Component/s: C++ Broker
    • Labels:
      None
    • Environment:

      CentOS 6.4, Qpid 0.24 RC1, Proton 0.4

      Description

      I have a C++ client based on the qpid.messaging / AMQP 1.0. This client has a container-id specified in the connection options. This client creates a receiver with following address:

      z/response.ABCFR_ABCFRALMMACC1.response_queue_1; { create: never, link:

      { name: 'response.ABCFR_ABCFRALMMACC1.response_queue_1', durable: false }

      }

      where z is a name of a topic. The client alone seems to be working fine. It creates the receiver and waits for a message.

      However, when I start second instance of the same program, it results in a broker crash. I assume it might be related to the fact that it uses the same container-id and link name.

      A trace log from the broker is attached.

      1. qpidd.log
        75 kB
        JAkub Scholz

        Activity

        Hide
        Justin Ross added a comment -
        Show
        Justin Ross added a comment - Released in Qpid 0.24, http://qpid.apache.org/releases/qpid-0.24/index.html
        Hide
        ASF subversion and git services added a comment -

        Commit 1512394 from Gordon Sim in branch 'qpid/branches/0.24'
        [ https://svn.apache.org/r1512394 ]

        QPID-5061: do exclusivity checks before registering link to avoid cancelling a subscription that did not succeed (merged from r1512218)

        Show
        ASF subversion and git services added a comment - Commit 1512394 from Gordon Sim in branch 'qpid/branches/0.24' [ https://svn.apache.org/r1512394 ] QPID-5061 : do exclusivity checks before registering link to avoid cancelling a subscription that did not succeed (merged from r1512218)
        Hide
        Justin Ross added a comment -

        Reviewed by Mick. Approved for 0.24.

        Show
        Justin Ross added a comment - Reviewed by Mick. Approved for 0.24.
        Hide
        michael goulish added a comment -

        review:

        This change has got to be correct. There cannot be a case where it is more correct to store a shared_ptr to a newed object before it has been initialized.

        Nihil Obstat. Imprimatur.

        Show
        michael goulish added a comment - review: This change has got to be correct. There cannot be a case where it is more correct to store a shared_ptr to a newed object before it has been initialized. Nihil Obstat. Imprimatur.
        Hide
        ASF subversion and git services added a comment -

        Commit 1512218 from Gordon Sim in branch 'qpid/trunk'
        [ https://svn.apache.org/r1512218 ]

        QPID-5061: do exclusivity checks before registering link to avoid cancelling a subscription that did not succeed

        Show
        ASF subversion and git services added a comment - Commit 1512218 from Gordon Sim in branch 'qpid/trunk' [ https://svn.apache.org/r1512218 ] QPID-5061 : do exclusivity checks before registering link to avoid cancelling a subscription that did not succeed
        Hide
        JAkub Scholz added a comment -

        Broker log file

        Show
        JAkub Scholz added a comment - Broker log file

          People

          • Assignee:
            Gordon Sim
            Reporter:
            JAkub Scholz
          • Votes:
            0 Vote for this issue
            Watchers:
            4 Start watching this issue

            Dates

            • Created:
              Updated:
              Resolved:

              Development