Qpid
  1. Qpid
  2. QPID-5005

Java Broker Plugin API has changed to need overridden getType() method in instances of PluginFactory

    Details

    • Type: Improvement Improvement
    • Status: Closed
    • Priority: Critical Critical
    • Resolution: Fixed
    • Affects Version/s: None
    • Fix Version/s: 0.24
    • Component/s: Java Tools
    • Labels:
      None

      Description

      The Java Broker Plugin API has changed to need overridden getType() method in instances of PluginFactory.

      This change caused the QMF2 plugin for the Java broker in /qpid/tools/src/java to break. The following patch fixes it.

      — qpid/tools/src/java/src/qpid-broker-plugins-management-qmf2/java/org/apache/qpid/server/qmf2/QmfManagementFactory.java (revision 1504825)
      +++ qpid/tools/src/java/src/qpid-broker-plugins-management-qmf2/java/org/apache/qpid/server/qmf2/QmfManagementFactory.java (working copy)
      @@ -76,4 +76,10 @@
      return null;
      }
      }
      +
      + @Override
      + public String getType()
      +

      { + return "QMF2 Management"; + }

      }

      I'll commit the fix to trunk, but I'm guessing that the Java broker changes that caused this to happen might mean that it's broken on the 0.24 release branch too.

        Activity

        Hide
        ASF subversion and git services added a comment -

        Commit 1504839 from Fraser Adams in branch 'qpid/trunk'
        [ https://svn.apache.org/r1504839 ]

        JIRA: QPID-5005 The Java Broker Plugin API has changed to need overridden getType() method in instances of PluginFactory. This commit adds getType() to QmfManagementFactory.java

        Show
        ASF subversion and git services added a comment - Commit 1504839 from Fraser Adams in branch 'qpid/trunk' [ https://svn.apache.org/r1504839 ] JIRA: QPID-5005 The Java Broker Plugin API has changed to need overridden getType() method in instances of PluginFactory. This commit adds getType() to QmfManagementFactory.java
        Hide
        Fraser Adams added a comment -

        Fixed on trunk

        Show
        Fraser Adams added a comment - Fixed on trunk
        Hide
        ASF subversion and git services added a comment -

        Commit 1504940 from Fraser Adams in branch 'qpid/branches/0'
        [ https://svn.apache.org/r1504940 ]

        JIRA: QPID-5008 Add Session.java class to 0.24 branch and merge QPID-5005 fix from trunk to 0.24

        Show
        ASF subversion and git services added a comment - Commit 1504940 from Fraser Adams in branch 'qpid/branches/0' [ https://svn.apache.org/r1504940 ] JIRA: QPID-5008 Add Session.java class to 0.24 branch and merge QPID-5005 fix from trunk to 0.24
        Hide
        Justin Ross added a comment -
        Show
        Justin Ross added a comment - Released in Qpid 0.24, http://qpid.apache.org/releases/qpid-0.24/index.html

          People

          • Assignee:
            Unassigned
            Reporter:
            Fraser Adams
          • Votes:
            0 Vote for this issue
            Watchers:
            3 Start watching this issue

            Dates

            • Created:
              Updated:
              Resolved:

              Development