Qpid
  1. Qpid
  2. QPID-4999

[Java Broker] Strip selector arguments from persistent bindings to non-topic exchanges created by buggy old clients

    Details

    • Type: Bug Bug
    • Status: Closed
    • Priority: Major Major
    • Resolution: Fixed
    • Affects Version/s: None
    • Fix Version/s: 0.24
    • Component/s: Java Broker
    • Labels:
      None

      Description

      With the addition of the ability to add selectors to queue bindings, we need to remove any arguments on bindings that were caused by the buggy behaviour of the JMS client. Previously such arguments would have been ignored, but upon upgrading the queue would now receive fewer messages than expected as the selector would take effect).

      This stripping of bindings should take effect when the store is first upgraded.

        Issue Links

          Activity

          Hide
          ASF subversion and git services added a comment -

          Commit 1504429 from Rob Godfrey in branch 'qpid/trunk'
          [ https://svn.apache.org/r1504429 ]

          QPID-4999 : [Java Broker] Strip selector arguments from persistent bindings to non-topic exchanges created by buggy old clients

          Show
          ASF subversion and git services added a comment - Commit 1504429 from Rob Godfrey in branch 'qpid/trunk' [ https://svn.apache.org/r1504429 ] QPID-4999 : [Java Broker] Strip selector arguments from persistent bindings to non-topic exchanges created by buggy old clients
          Hide
          ASF subversion and git services added a comment -

          Commit 1504451 from Rob Godfrey in branch 'qpid/trunk'
          [ https://svn.apache.org/r1504451 ]

          QPID-4999 : [Java Broker] Strip selector arguments from persistent bindings to non-topic exchanges created by buggy old clients

          Show
          ASF subversion and git services added a comment - Commit 1504451 from Rob Godfrey in branch 'qpid/trunk' [ https://svn.apache.org/r1504451 ] QPID-4999 : [Java Broker] Strip selector arguments from persistent bindings to non-topic exchanges created by buggy old clients
          Hide
          Robbie Gemmell added a comment -

          As already discussed elsewhere, looks good other than not upgrading the store version, which has now been handled via QPID-5009.

          This needs to be requested for inclusion in 0.24 so that people upgrading don't find their broker starts behaving quite differently.

          Show
          Robbie Gemmell added a comment - As already discussed elsewhere, looks good other than not upgrading the store version, which has now been handled via QPID-5009 . This needs to be requested for inclusion in 0.24 so that people upgrading don't find their broker starts behaving quite differently.
          Hide
          Justin Ross added a comment -

          Reviewed by Robbie. Approved for 0.24.

          Show
          Justin Ross added a comment - Reviewed by Robbie. Approved for 0.24.
          Hide
          ASF subversion and git services added a comment -

          Commit 1505820 from Rob Godfrey in branch 'qpid/branches/0'
          [ https://svn.apache.org/r1505820 ]

          QPID-4999 : merged to 0.24 branch (1504429,1504451)

          Show
          ASF subversion and git services added a comment - Commit 1505820 from Rob Godfrey in branch 'qpid/branches/0' [ https://svn.apache.org/r1505820 ] QPID-4999 : merged to 0.24 branch (1504429,1504451)
          Hide
          Justin Ross added a comment -
          Show
          Justin Ross added a comment - Released in Qpid 0.24, http://qpid.apache.org/releases/qpid-0.24/index.html

            People

            • Assignee:
              Unassigned
              Reporter:
              Rob Godfrey
            • Votes:
              0 Vote for this issue
              Watchers:
              4 Start watching this issue

              Dates

              • Created:
                Updated:
                Resolved:

                Development