Qpid
  1. Qpid
  2. QPID-4973

[Java Broker] Refactor DurableConfigurationStore interface to be in terms of ConfiguredObject rather than implementation classes

    Details

    • Type: Improvement Improvement
    • Status: Closed
    • Priority: Major Major
    • Resolution: Fixed
    • Affects Version/s: None
    • Fix Version/s: 0.23
    • Component/s: Java Broker
    • Labels:
      None

      Description

      As part of the ongoing changes to the Java Broker configuration model, make the DurableConfigurationStore (essentially the config store for a vhost) expose only a generic interface for configured objects, and not restrict to concrete implementation classes such as Queue, Exchange, Binding, etc.

      (Note that the representation of the objects in the BDB and JDBC/Derby stores is already in a generic form.

        Activity

        Transition Time In Source Status Execution Times Last Executer Last Execution Date
        Open Open Resolved Resolved
        15d 6h 11m 1 Rob Godfrey 17/Jul/13 21:34
        Resolved Resolved Closed Closed
        52d 16h 11m 1 Justin Ross 08/Sep/13 13:45
        Justin Ross made changes -
        Status Resolved [ 5 ] Closed [ 6 ]
        Hide
        Justin Ross added a comment -
        Show
        Justin Ross added a comment - Released in Qpid 0.24, http://qpid.apache.org/releases/qpid-0.24/index.html
        Rob Godfrey made changes -
        Status Open [ 1 ] Resolved [ 5 ]
        Fix Version/s 0.23 [ 12324273 ]
        Resolution Fixed [ 1 ]
        Hide
        Rob Godfrey added a comment -

        Steps 2. and 3. above will be addressed in the 0.26 timeframe

        Show
        Rob Godfrey added a comment - Steps 2. and 3. above will be addressed in the 0.26 timeframe
        Hide
        Rob Godfrey added a comment -

        Gah - the above commit (r1500047) should have been against QPID-4979

        Show
        Rob Godfrey added a comment - Gah - the above commit (r1500047) should have been against QPID-4979
        Hide
        ASF subversion and git services added a comment -

        Commit 1500047 from Rob Godfrey
        [ https://svn.apache.org/r1500047 ]

        QPID-4973 : [Java Broker] Refactor DurableConfigurationStore interface to be in terms of ConfiguredObject rather than implementation classes

        Show
        ASF subversion and git services added a comment - Commit 1500047 from Rob Godfrey [ https://svn.apache.org/r1500047 ] QPID-4973 : [Java Broker] Refactor DurableConfigurationStore interface to be in terms of ConfiguredObject rather than implementation classes
        Hide
        Rob Godfrey added a comment -

        First commit exposes the API as a tuple of id, type, attributes and moves the conversion from the implementation objects into DurableConfigurationStoreHelper.

        Outstanding steps are:

        1. Use simple name (e.g. "Queue") rather than full class names for types (cf broker json store)
        2. move creation/removal logic into a central location
        3. allow for saving of additional attributes, and reconcile model names and queue creation names for the attributes

        Show
        Rob Godfrey added a comment - First commit exposes the API as a tuple of id, type, attributes and moves the conversion from the implementation objects into DurableConfigurationStoreHelper. Outstanding steps are: 1. Use simple name (e.g. "Queue") rather than full class names for types (cf broker json store) 2. move creation/removal logic into a central location 3. allow for saving of additional attributes, and reconcile model names and queue creation names for the attributes
        Hide
        ASF subversion and git services added a comment -

        Commit 1498976 from Rob Godfrey
        [ https://svn.apache.org/r1498976 ]

        QPID-4973 : [Java Broker] Refactor DurableConfigurationStore

        Show
        ASF subversion and git services added a comment - Commit 1498976 from Rob Godfrey [ https://svn.apache.org/r1498976 ] QPID-4973 : [Java Broker] Refactor DurableConfigurationStore
        Rob Godfrey made changes -
        Description As part of the ongoing changes to the Java Broker configuration model, make the DurableConfigurationStore (essentially the config store for a vhost) expose only a generic interface for configured objects, and not restrict to concrete implementation classes such as Queue, Exchange, Binding, etc.

        (Note that the representation of the objects in the BDB and JDBC/Derby stores is already in a generic form.
        Rob Godfrey made changes -
        Field Original Value New Value
        Issue Type Bug [ 1 ] Improvement [ 4 ]
        Rob Godfrey created issue -

          People

          • Assignee:
            Rob Godfrey
            Reporter:
            Rob Godfrey
          • Votes:
            0 Vote for this issue
            Watchers:
            3 Start watching this issue

            Dates

            • Created:
              Updated:
              Resolved:

              Development