Qpid
  1. Qpid
  2. QPID-4908

[Java Broker] Expose queue attributes MessageGroupKey and MessageGroupSharedGroups via queue MBean

    Details

    • Type: Improvement Improvement
    • Status: Closed
    • Priority: Major Major
    • Resolution: Fixed
    • Affects Version/s: 0.18, 0.20, 0.22
    • Fix Version/s: 0.23
    • Component/s: Java Broker
    • Labels:
      None

      Description

      Expose queue attributes MessageGroupKey and MessageGroupSharedGroups via queue MBean

        Activity

        Hide
        Alex Rudyy added a comment -

        Robbie,
        Could you please review the changes in revision http://svn.apache.org/r1489872 ?

        Show
        Alex Rudyy added a comment - Robbie, Could you please review the changes in revision http://svn.apache.org/r1489872 ?
        Hide
        Robbie Gemmell added a comment -
        +    @MBeanAttribute(name="MessageGroupSharedGroups", description="Indicates C++ compatibility mode, the Broker enforces a looser guarantee, nameley that all the currently unacknowledged messages in a group will be sent to the same consumer. This means that only one consumer can be processing messages from a particular group at a given time. When the consumer acknowledges all of its acquired messages, then the broker may pass the next pending message from that group to a different consumer")
        +    boolean isMessageGroupSharedGroups();
        

        The attribute description for shared groups seems rather verbose. Anyone using it should be reading the documentation for grouping to understand it fully, so this just needs to be a small pointer. What about something simpler like "If set indicates that while two messages of the same group cannot be processed by different consumers concurrently, no guarantee is made that subsequent messages are always sent to the same consumer"?

        Show
        Robbie Gemmell added a comment - + @MBeanAttribute(name= "MessageGroupSharedGroups" , description= "Indicates C++ compatibility mode, the Broker enforces a looser guarantee, nameley that all the currently unacknowledged messages in a group will be sent to the same consumer. This means that only one consumer can be processing messages from a particular group at a given time. When the consumer acknowledges all of its acquired messages, then the broker may pass the next pending message from that group to a different consumer" ) + boolean isMessageGroupSharedGroups(); The attribute description for shared groups seems rather verbose. Anyone using it should be reading the documentation for grouping to understand it fully, so this just needs to be a small pointer. What about something simpler like "If set indicates that while two messages of the same group cannot be processed by different consumers concurrently, no guarantee is made that subsequent messages are always sent to the same consumer"?
        Hide
        Alex Rudyy added a comment -

        Robbie,

        I changed the description text to the one you has sugessted and committed the change in revision http://svn.apache.org/r1489903 . Could you please review it?

        Show
        Alex Rudyy added a comment - Robbie, I changed the description text to the one you has sugessted and committed the change in revision http://svn.apache.org/r1489903 . Could you please review it?
        Hide
        Robbie Gemmell added a comment -

        Looks good.

        Show
        Robbie Gemmell added a comment - Looks good.
        Hide
        Justin Ross added a comment -
        Show
        Justin Ross added a comment - Released in Qpid 0.24, http://qpid.apache.org/releases/qpid-0.24/index.html

          People

          • Assignee:
            Robbie Gemmell
            Reporter:
            Alex Rudyy
          • Votes:
            0 Vote for this issue
            Watchers:
            3 Start watching this issue

            Dates

            • Created:
              Updated:
              Resolved:

              Development