Qpid
  1. Qpid
  2. QPID-4886

Pass non-const reference to Message in QueueObserver functions.

    Details

    • Type: Improvement Improvement
    • Status: Closed
    • Priority: Major Major
    • Resolution: Fixed
    • Affects Version/s: 0.23
    • Fix Version/s: 0.23
    • Component/s: C++ Broker
    • Labels:
      None

      Description

      The HA plugin needs to modify a message in QueueObserver::enqueued to attach a HA ID to it. Other plugins may need to similarly annotate messages at QueueObserver call points.
      Need to remove the "const" qualifier for Message arguments to QueueObserver methods to enable this.

        Activity

        Hide
        Alan Conway added a comment -

        Review at https://reviews.apache.org/r/11378/

        The proposal is to leave the const qualifier in QueueObserver, since the name "observer" implies no change is made to the thing observed.
        We will introduce a new interface for entities that need to modify messages as they go through the system.

        Show
        Alan Conway added a comment - Review at https://reviews.apache.org/r/11378/ The proposal is to leave the const qualifier in QueueObserver, since the name "observer" implies no change is made to the thing observed. We will introduce a new interface for entities that need to modify messages as they go through the system.
        Hide
        ASF subversion and git services added a comment -

        Commit 1487579 from aconway
        [ https://svn.apache.org/r1487579 ]

        QPID-4886: Pass non-const reference to Message in QueueObserver functions.

        Instead of modifying QueueObserver, a new class MessageInterceptor was
        introduced to allow messages to be modified.

        Show
        ASF subversion and git services added a comment - Commit 1487579 from aconway [ https://svn.apache.org/r1487579 ] QPID-4886 : Pass non-const reference to Message in QueueObserver functions. Instead of modifying QueueObserver, a new class MessageInterceptor was introduced to allow messages to be modified.
        Hide
        Alan Conway added a comment -

        ------------------------------------------------------------------------
        r1487579 | aconway | 2013-05-29 14:03:59 -0400 (Wed, 29 May 2013) | 5 lines

        QPID-4886: Pass non-const reference to Message in QueueObserver functions.

        Instead of modifying QueueObserver, a new class MessageInterceptor was
        introduced to allow messages to be modified.

        ------------------------------------------------------------------------

        Show
        Alan Conway added a comment - ------------------------------------------------------------------------ r1487579 | aconway | 2013-05-29 14:03:59 -0400 (Wed, 29 May 2013) | 5 lines QPID-4886 : Pass non-const reference to Message in QueueObserver functions. Instead of modifying QueueObserver, a new class MessageInterceptor was introduced to allow messages to be modified. ------------------------------------------------------------------------
        Hide
        ASF subversion and git services added a comment -

        Commit 1487816 from gsim
        [ https://svn.apache.org/r1487816 ]

        QPID-4886: fix autoconf distcheck

        Show
        ASF subversion and git services added a comment - Commit 1487816 from gsim [ https://svn.apache.org/r1487816 ] QPID-4886 : fix autoconf distcheck
        Hide
        Justin Ross added a comment -
        Show
        Justin Ross added a comment - Released in Qpid 0.24, http://qpid.apache.org/releases/qpid-0.24/index.html

          People

          • Assignee:
            Alan Conway
            Reporter:
            Alan Conway
          • Votes:
            0 Vote for this issue
            Watchers:
            3 Start watching this issue

            Dates

            • Created:
              Updated:
              Resolved:

              Development