Qpid
  1. Qpid
  2. QPID-4864

The JMS client shouldn't hold a lock when creating a messge

    Details

    • Type: Bug Bug
    • Status: Closed
    • Priority: Major Major
    • Resolution: Fixed
    • Affects Version/s: 0.16, 0.18, 0.20, 0.22
    • Fix Version/s: 0.23
    • Component/s: Java Client
    • Labels:
      None

      Description

      The JMS client needlessly holds the failover mutex when creating a text message. It also sets the session.

      When creating messages to be sent, they should be just value objects and should not hold any state.

      When constructing a message to be given to the consumer, we have to set the session, so acknowledge can be called. But not when we create messages for sending.

        Activity

        Hide
        Justin Ross added a comment -
        Show
        Justin Ross added a comment - Released in Qpid 0.24, http://qpid.apache.org/releases/qpid-0.24/index.html
        Hide
        Rajith Attapattu added a comment -

        Removed the lock. Fix committed at http://svn.apache.org/r1483877

        Show
        Rajith Attapattu added a comment - Removed the lock. Fix committed at http://svn.apache.org/r1483877

          People

          • Assignee:
            Rajith Attapattu
            Reporter:
            Rajith Attapattu
          • Votes:
            0 Vote for this issue
            Watchers:
            2 Start watching this issue

            Dates

            • Created:
              Updated:
              Resolved:

              Development