[QPID-4820] Variant decoding/conversion incorrect for at least bin8, int8, uint8 data types

• Type: Bug
• Status: Closed
• Priority: Major
• Resolution: Fixed
• Fix Version/s: 0.23
• Assignee: Gordon Sim
• Reporter: Andy Goldstein
• Created: 08/May/13 14:16
• Updated: 08/Sep/13 13:37
• Resolved: 08/May/13 15:39

Description

In the toVariant method in Codecs.cpp (https://github.com/apache/qpid/blob/trunk/qpid/cpp/src/qpid/amqp_0_10/Codecs.cpp#L99), the case statements for bin8, int8, and uint8 are incorrect.

bin8 should be 0x00 (it's currently 0x01)
int8 should be 0x01 (it's currently 0x02)
uint8 should be 0x02 (it's currently 0x03)

If you send a message like

message.getProperties["key"] = boost::uint8_t(255)

When you receive it, the value of that property comes out as -1, as the client incorrectly decodes the uint8 as an int8.

It might be worth reviewing the entire switch block to see if anything else needs adjusting.