Qpid
  1. Qpid
  2. QPID-4759

qpidd --help should show sasl config path default

    Details

    • Type: Bug Bug
    • Status: Closed
    • Priority: Major Major
    • Resolution: Fixed
    • Affects Version/s: None
    • Fix Version/s: 0.23
    • Component/s: None
    • Labels:
      None

      Description

      --help output does not show the sasl config path default, which the Cyrus SASL library sets as "/etc/sasl2"

        Activity

        Hide
        michael goulish added a comment -

        After discussing with astitcher –

        This bug is less minor than we thought.

        Cyrus SASL should not be allowed to default to /etc/sasl2.
        It should use something like $

        {prefix}

        /etc for the sysconfdir
        like everything else.

        The location of sysconfdir comes from the build system,
        and this fix must work with both cmake and autotools.
        Autotools is deprecated, but still 'live' at this time.

        I'm promoting it one level in priority.
        Unfortunately there is no 'medium' level.

        Show
        michael goulish added a comment - After discussing with astitcher – This bug is less minor than we thought. Cyrus SASL should not be allowed to default to /etc/sasl2. It should use something like $ {prefix} /etc for the sysconfdir like everything else. The location of sysconfdir comes from the build system, and this fix must work with both cmake and autotools. Autotools is deprecated, but still 'live' at this time. I'm promoting it one level in priority. Unfortunately there is no 'medium' level.
        Hide
        michael goulish added a comment -

        fixed in rev 1477435.

        Show
        michael goulish added a comment - fixed in rev 1477435.
        Hide
        Gordon Sim added a comment -

        "Cyrus SASL should not be allowed to default to /etc/sasl2" - why? I believe that is standard for all other cyrus sasl based config files. What is the impact on upgrade from this change?

        Show
        Gordon Sim added a comment - "Cyrus SASL should not be allowed to default to /etc/sasl2" - why? I believe that is standard for all other cyrus sasl based config files. What is the impact on upgrade from this change?
        Hide
        Justin Ross added a comment -

        I'd put it differently: Qpidd's use of sasl should honor the build-time determined system-config prefix. The standard system config prefix is indeed /etc, but it isn't always. For instance, a user with a locally built cyrus sasl may have it at /usr/local/etc, and another unix variant may have it somewhere else altogether.

        If there's any impact on upgrade from this, that's a bug.

        Show
        Justin Ross added a comment - I'd put it differently: Qpidd's use of sasl should honor the build-time determined system-config prefix. The standard system config prefix is indeed /etc, but it isn't always. For instance, a user with a locally built cyrus sasl may have it at /usr/local/etc, and another unix variant may have it somewhere else altogether. If there's any impact on upgrade from this, that's a bug.
        Show
        Justin Ross added a comment - For reference: http://www.gnu.org/prep/standards/html_node/Directory-Variables.html
        Hide
        Gordon Sim added a comment -

        The commit changes the value of sasl-config-path. Previously it was not set, therefore the default is determined by cyrus libs themselves. Now it is set to something explicit. If that doesn't match the cyrus default, then an upgrade will no longer point at the correct path. Note also that older versions of cyrus don't let you set the path.

        Show
        Gordon Sim added a comment - The commit changes the value of sasl-config-path. Previously it was not set, therefore the default is determined by cyrus libs themselves. Now it is set to something explicit. If that doesn't match the cyrus default, then an upgrade will no longer point at the correct path. Note also that older versions of cyrus don't let you set the path.
        Hide
        michael goulish added a comment -

        I removed all my previous changes, and settled for just an extra bit of comment that prints out at the far right edge of the --help output.

        Show
        michael goulish added a comment - I removed all my previous changes, and settled for just an extra bit of comment that prints out at the far right edge of the --help output.
        Hide
        Justin Ross added a comment -
        Show
        Justin Ross added a comment - Released in Qpid 0.24, http://qpid.apache.org/releases/qpid-0.24/index.html

          People

          • Assignee:
            michael goulish
            Reporter:
            michael goulish
          • Votes:
            0 Vote for this issue
            Watchers:
            3 Start watching this issue

            Dates

            • Created:
              Updated:
              Resolved:

              Development