[QPID-4720] C++ Broker Headers exchange match comparison self tests use stale comparison code

• Type: Bug
• Status: Closed
• Priority: Major
• Resolution: Fixed
• Affects Version/s: 0.20
• Fix Version/s: 0.23
• Component/s: C++ Broker
• Assignee: Charles E. Rolke
• Reporter: Charles E. Rolke
• Created: 05/Apr/13 19:18
• Updated: 08/Sep/13 13:37
• Resolved: 29/Apr/13 20:23

Description

Steps to Reproduce:
1. Use the old Python client API and do this:

session.exchange_bind(exchange="MyHeadersExchange", queue="MyQueue", arguments=

{"x-match":"all", "MyHeader":1}

)

2. Use the new C++ messaging API to send a message like this:

Message msg(;
msg.getProperties()["MyHeader"] = boost::uint16_t(1);

3. Use qpid-stat to see if the exchange routed the message to the queue, or if it was dropped. In this case, it will be incorrectly dropped.

Actual results: Message is dropped

Expected results: Message is delivered into queue MyQueue

Additional info: It looks like the binding generated via Python is a match on the value 1L. If we create a C++ client to set up the binding, it creates a match based on 1. It looks like the headers exchange thinks that 1 (2-bytes) isn't the same as 1L (4-bytes).
----------

Headers exchange looks at the value type and sees that they are different and so does not compare the value data.

I'm comfortable saying that the comparison is based on the header entry's type and data value. If the types don't match then the comparison fails. This is how the code works now.

To match "comparable" data types then the match must cover [int uint]_[8 16 32 64], and possibly float and double. Even a string data type could be matched "1", "0x1", and so on. This could be an awful lot of development effort and testing.

What is the correct behavior?