Details

    • Type: Bug Bug
    • Status: Closed
    • Priority: Major Major
    • Resolution: Fixed
    • Affects Version/s: 0.22
    • Fix Version/s: 0.23
    • Component/s: C++ Broker
    • Labels:
      None

      Description

      Though e.g. creation of queues and exchanges is governed by ACL rules, creation of connections is not and this should be rectified.

        Activity

        Hide
        Justin Ross added a comment -
        Show
        Justin Ross added a comment - Released in Qpid 0.24, http://qpid.apache.org/releases/qpid-0.24/index.html
        Hide
        ASF subversion and git services added a comment -

        Commit 1496545 from Gordon Sim
        [ https://svn.apache.org/r1496545 ]

        QPID-4712: fixes for windows, rhel5

        Show
        ASF subversion and git services added a comment - Commit 1496545 from Gordon Sim [ https://svn.apache.org/r1496545 ] QPID-4712 : fixes for windows, rhel5
        Hide
        Gordon Sim added a comment -

        The goal is to ensure that enabling AMQP 1.0 doesn't allow any existing authorisation policy to be circumvented. The existing rules are heavily influenced (distorted?) by AMQP 0-10 without directly following the that version in full. A redesign of the permissioning model to be more generic would make things more intuitive for AMQP 1.0 users, but is considered out of scope for the time being.

        Link attachment (i.e. creating a sender or receiver) will always require access permission to the node in question (i.e. the queue or exchange). Generally there will be other permissions required as well.

        To attach as a sender to a queue, publish permission is required for the default exchange (amq.default keyword in ACL file) with the queue name as the routing key. For a sending link to an exchange the publish permission cannot be checked on attach since the routing key is unknown at that point. This is similar to 0-10 and the publish permission will be checked (if and only if there are any publish rules) for each message (again, exactly like 0-10).

        To attach as a receiver from a queue, consume permission is also required for the queue in question. To attach as a receiver from an exchange, create and consume permission will be required for the subscription queue. The name of this is chosen by the broker, but it uses the container id (which can be set as a connection option in qpid::messaging) and the link name (which can be set as the name proerty in link properties of address in qpid::messaging). In addition bind permission is required for the exchange in question. Note however that unbind permission is not required in order to detach, as that permission is implied (it will happen anyway).

        In the 1.0 codepath, the properties used in checking access etc are those of the node (queue or exchange). In AMQP 0-10 by contrast the fields of the command being checked are used instead (which leads to some anomalies in my view since e.g. queue-query doesn't involve any test for autodelete, exclusive etc as would a passive declare).

        Show
        Gordon Sim added a comment - The goal is to ensure that enabling AMQP 1.0 doesn't allow any existing authorisation policy to be circumvented. The existing rules are heavily influenced (distorted?) by AMQP 0-10 without directly following the that version in full. A redesign of the permissioning model to be more generic would make things more intuitive for AMQP 1.0 users, but is considered out of scope for the time being. Link attachment (i.e. creating a sender or receiver) will always require access permission to the node in question (i.e. the queue or exchange). Generally there will be other permissions required as well. To attach as a sender to a queue, publish permission is required for the default exchange (amq.default keyword in ACL file) with the queue name as the routing key. For a sending link to an exchange the publish permission cannot be checked on attach since the routing key is unknown at that point. This is similar to 0-10 and the publish permission will be checked (if and only if there are any publish rules) for each message (again, exactly like 0-10). To attach as a receiver from a queue, consume permission is also required for the queue in question. To attach as a receiver from an exchange, create and consume permission will be required for the subscription queue. The name of this is chosen by the broker, but it uses the container id (which can be set as a connection option in qpid::messaging) and the link name (which can be set as the name proerty in link properties of address in qpid::messaging). In addition bind permission is required for the exchange in question. Note however that unbind permission is not required in order to detach, as that permission is implied (it will happen anyway). In the 1.0 codepath, the properties used in checking access etc are those of the node (queue or exchange). In AMQP 0-10 by contrast the fields of the command being checked are used instead (which leads to some anomalies in my view since e.g. queue-query doesn't involve any test for autodelete, exclusive etc as would a passive declare).
        Hide
        ASF subversion and git services added a comment -

        Commit 1496466 from Gordon Sim
        [ https://svn.apache.org/r1496466 ]

        QPID-4712: authorisation for AMQP 1.0 connections

        Show
        ASF subversion and git services added a comment - Commit 1496466 from Gordon Sim [ https://svn.apache.org/r1496466 ] QPID-4712 : authorisation for AMQP 1.0 connections
        Hide
        Gordon Sim added a comment -

        Initial patch for connection approval in 1.0 available for review: https://reviews.apache.org/r/12029/

        Show
        Gordon Sim added a comment - Initial patch for connection approval in 1.0 available for review: https://reviews.apache.org/r/12029/

          People

          • Assignee:
            Gordon Sim
            Reporter:
            Gordon Sim
          • Votes:
            0 Vote for this issue
            Watchers:
            4 Start watching this issue

            Dates

            • Created:
              Updated:
              Resolved:

              Development