[QPID-4696] [Java Broker] QPID-4461 review changes

• Type: Bug
• Status: Resolved
• Priority: Major
• Resolution: Fixed
• Affects Version/s: 0.21
• Component/s: Broker-J
• Assignee: Alex Rudyy
• Reporter: Robbie Gemmell
• Created: 03/Apr/13 13:14
• Updated: 23/Apr/13 15:24
• Resolved: 23/Apr/13 15:24

Description

JIRA to perfom review changes from QPID-4661. The initial changes are already on the 0.22 branch, whereas these are currently going to go on trunk/0.23. Creating new JRIA as a holder in case they remain in 0.23/0.24 only.

1. On the attribute editing screen, the attributes are scattered in a completely different order than the viewing screen. Should probably be grouped similarly to the viewing screen.

1. We should show the units of the setting (where appropriate) as part of its 'pretty printing' text.

1. I think we can now remove GroupPrincipalAccessor now that it is being created all the time and not up-front, it is just holding a collection and then being thrown away, i.e not doing anything useful.

1. We should be able to set the flow control attributes independently of each other, it is not required that you change both at the same time. The only restriction is that the flow control size can’t be less than the flow resume size.

1. DEFAULT_GROUP_PROFIDER_NAME typo

1. Dont these changes all occur on the config thread? If so we shouldn't need to comment on thread safety as there is only one thread involved.
   BrokerAdapter: "// the calls below are not thread safe but they should be fine in a management mode"
   SecurityManager:
   "// the code below is not thread safe, however, it should be fine in a management mode
   + // as there will be no user connected"

Issue Links

• relates to: QPID-4661 [Java Broker] Add UI into web management console to edit broker attributes