Qpid
  1. Qpid
  2. QPID-4694

[Java Broker] the JSON config file is not saved after startup until promted by additional change, which can result in unecessary generation of new IDs for objects on each startup

    Details

    • Type: Bug Bug
    • Status: Closed
    • Priority: Major Major
    • Resolution: Fixed
    • Affects Version/s: None
    • Fix Version/s: 0.23
    • Component/s: Java Broker
    • Labels:
      None

      Description

      The JSON config file is not saved after startup until promted by additional change, which can result in unecessary generation of new IDs for objects on each startup.

      For example, upon the first startup the initia-config within the broker jar is written out to disk and then loaded. This prompts generation of IDs for the objects in the configuration, but does not cause the file to be saved. If the broker is simply restarted the same generation of IDs occurs.

      Similarly, if a user edited the config file and added a new object but did not specify an ID, one would be generated at each restart until they edited the config with the broker running and prompted it to save the current ID for the object.

      The config store file should be immediately saved if any Ids are generated during startup.

        Activity

        Hide
        Robbie Gemmell added a comment -

        Change made in http://svn.apache.org/r1463917

        Alex, can you review please?

        I'd like to request this for 0.22.

        Show
        Robbie Gemmell added a comment - Change made in http://svn.apache.org/r1463917 Alex, can you review please? I'd like to request this for 0.22.
        Hide
        Alex Rudyy added a comment -

        The changes look good to me. We should definitely ask to include this in 0.22.

        Show
        Alex Rudyy added a comment - The changes look good to me. We should definitely ask to include this in 0.22.
        Hide
        Justin Ross added a comment -

        Reviewed by Alex. Approved for 0.22.

        Show
        Justin Ross added a comment - Reviewed by Alex. Approved for 0.22.
        Hide
        Robbie Gemmell added a comment -

        merged to 0.22 branch in: http://svn.apache.org/r1464463

        Show
        Robbie Gemmell added a comment - merged to 0.22 branch in: http://svn.apache.org/r1464463
        Hide
        Justin Ross added a comment -
        Show
        Justin Ross added a comment - Released in Qpid 0.24, http://qpid.apache.org/releases/qpid-0.24/index.html

          People

          • Assignee:
            Alex Rudyy
            Reporter:
            Robbie Gemmell
          • Votes:
            0 Vote for this issue
            Watchers:
            3 Start watching this issue

            Dates

            • Created:
              Updated:
              Resolved:

              Development