Qpid
  1. Qpid
  2. QPID-4691

[Java Broker] update web UI handling of SSL attributes and make the broker validate port attributes more closely to avoid illegal configurations which prevent start-up

    Details

    • Type: Bug Bug
    • Status: Closed
    • Priority: Critical Critical
    • Resolution: Fixed
    • Affects Version/s: 0.21, 0.22
    • Fix Version/s: 0.23
    • Component/s: Java Broker
    • Labels:
      None

      Description

      On setting of broker attributes the keystore/trustore/peerstore attributes only validated when path is changed. As result, when password or alias is changed no validation happens and invalid values can be stored.

      On setting of port attributes only attribute types are validated. As result if SSL port is configured without keystore or need/wantClientAuthorisation. attributes are set without truststore the following broker start fails as broker cannot bind to SSL port without keystore/truststore accordingly.

      The web management port UI should allow the setting of need/wantClientAuthorisation attributes only when SSL transport is selected.

      Broker UI to edit keystore/trustore/perrstore password should not require the setting of the password every time when path to keystore/trustore/perrstore is changed.

        Activity

        Hide
        Justin Ross added a comment -
        Show
        Justin Ross added a comment - Released in Qpid 0.24, http://qpid.apache.org/releases/qpid-0.24/index.html
        Hide
        Alex Rudyy added a comment -

        Merged into 0.22 branch in revision http://svn.apache.org/r1464485

        Show
        Alex Rudyy added a comment - Merged into 0.22 branch in revision http://svn.apache.org/r1464485
        Hide
        Justin Ross added a comment -

        Reviewed by Robbie. Approved for 0.22.

        A note in passing: this issue bundles together a high priority bug fix (scenario where invalid values can be stored) with other improvements. That's not nice from a triage perspective.

        Show
        Justin Ross added a comment - Reviewed by Robbie. Approved for 0.22. A note in passing: this issue bundles together a high priority bug fix (scenario where invalid values can be stored) with other improvements. That's not nice from a triage perspective.
        Hide
        Robbie Gemmell added a comment -

        Looks good to me, we should request this for 0.22.

        Show
        Robbie Gemmell added a comment - Looks good to me, we should request this for 0.22.
        Hide
        Alex Rudyy added a comment -

        Robbie,

        Could you please review the changes in revision http://svn.apache.org/r1463626 ?

        Show
        Alex Rudyy added a comment - Robbie, Could you please review the changes in revision http://svn.apache.org/r1463626 ?

          People

          • Assignee:
            Robbie Gemmell
            Reporter:
            Alex Rudyy
          • Votes:
            0 Vote for this issue
            Watchers:
            3 Start watching this issue

            Dates

            • Created:
              Updated:
              Resolved:

              Development