Qpid
  1. Qpid
  2. QPID-4677

[Java Broker] fix incorrect attribute names, group inheritable defaults and add missing ones

    Details

    • Type: Bug Bug
    • Status: Resolved
    • Priority: Major Major
    • Resolution: Fixed
    • Affects Version/s: 0.21, 0.22
    • Fix Version/s: 0.22
    • Component/s: Java Broker
    • Labels:
      None

      Description

      The introduction of the new broker level configuration store has exposed some issues with the attribute on the Broker, VirtualHost, Queue, Connection etc objects.

      There is a naming mismatch between some of the the alert threshold attributes on the Queue and the inheritable defaults for those values defined at the VirtualHost and Broker level. These names need to be reconciled.

      The attribute names of the inheritable defaults do not lend themselves to clarity as to which attributes affect the Broker, VirtualHost etc directly and those which are instead intended as inheritable defaults for children objects such as VirtualHosts, Connections, Queues etc. The attribute names should be prefixed with the object type to group them and clarify their influence.

      Finally, there is currently no way to configure the store TransactionTimeout functionality at the broker-wide level, so desire to use this functionality would force users into using the now otherwise optional virtualhost XML configuration files. Inheritable defaults should be added to the Broker for this.

        Activity

        Hide
        Robbie Gemmell added a comment -

        It would be good to ensure these changes occur at the same time as the introduction of the new JSON configuration to avoid further disruption to configuration by changing them later. This would require merging this change to the 0.22 release branch, which will have to be requested once the modificatiosn land on trunk / 0.23.

        Show
        Robbie Gemmell added a comment - It would be good to ensure these changes occur at the same time as the introduction of the new JSON configuration to avoid further disruption to configuration by changing them later. This would require merging this change to the 0.22 release branch, which will have to be requested once the modificatiosn land on trunk / 0.23.
        Hide
        Alex Rudyy added a comment - - edited

        Robbie,
        Could you please review the following commits addressing the issue:
        http://svn.apache.org/r1462472
        http://svn.apache.org/r1462471
        http://svn.apache.org/r1462470
        http://svn.apache.org/r1462550

        Show
        Alex Rudyy added a comment - - edited Robbie, Could you please review the following commits addressing the issue: http://svn.apache.org/r1462472 http://svn.apache.org/r1462471 http://svn.apache.org/r1462470 http://svn.apache.org/r1462550
        Hide
        Robbie Gemmell added a comment -

        One of the changes is actually a fix for an earlier JIRA (QPID-4661) so I have commented on it to that effect, leaving the following commits for this JIRA:

        http://svn.apache.org/r1462471
        http://svn.apache.org/r1462472
        http://svn.apache.org/r1462550

        Show
        Robbie Gemmell added a comment - One of the changes is actually a fix for an earlier JIRA ( QPID-4661 ) so I have commented on it to that effect, leaving the following commits for this JIRA: http://svn.apache.org/r1462471 http://svn.apache.org/r1462472 http://svn.apache.org/r1462550
        Hide
        Robbie Gemmell added a comment - - edited

        Changes look good to me. I made a further trivial change (reorder some lines to group them for clarity, rename one constant):
        http://svn.apache.org/r1463064
        http://svn.apache.org/r1463073

        I will request these for 0.22, along with the commit noted for QPID-4661 since it is actually a dependency of these changes.

        Show
        Robbie Gemmell added a comment - - edited Changes look good to me. I made a further trivial change (reorder some lines to group them for clarity, rename one constant): http://svn.apache.org/r1463064 http://svn.apache.org/r1463073 I will request these for 0.22, along with the commit noted for QPID-4661 since it is actually a dependency of these changes.
        Hide
        Justin Ross added a comment -

        Reviewed by Robbie. Approved for 0.22.

        Show
        Justin Ross added a comment - Reviewed by Robbie. Approved for 0.22.
        Hide
        Robbie Gemmell added a comment -

        r1462471 was merged via http://svn.apache.org/r1463162
        r1462472 was merged via http://svn.apache.org/r1463165
        r1462550 was merged via http://svn.apache.org/r1463167
        r1463064 was merged via http://svn.apache.org/r1463187
        r1463073 was merged via http://svn.apache.org/r1463188

        Show
        Robbie Gemmell added a comment - r1462471 was merged via http://svn.apache.org/r1463162 r1462472 was merged via http://svn.apache.org/r1463165 r1462550 was merged via http://svn.apache.org/r1463167 r1463064 was merged via http://svn.apache.org/r1463187 r1463073 was merged via http://svn.apache.org/r1463188

          People

          • Assignee:
            Robbie Gemmell
            Reporter:
            Robbie Gemmell
          • Votes:
            0 Vote for this issue
            Watchers:
            3 Start watching this issue

            Dates

            • Created:
              Updated:
              Resolved:

              Development