Qpid
  1. Qpid
  2. QPID-4645

[Java broker] add plugins as runtime dependencies in the broker pom, and make the optional bdbstore module dep scopes in line with other plugins

    Details

    • Type: Improvement Improvement
    • Status: Resolved
    • Priority: Major Major
    • Resolution: Fixed
    • Affects Version/s: None
    • Fix Version/s: 0.21
    • Component/s: Java Broker
    • Labels:
      None

      Description

      The broker module does not depend on the broker-plugins at compile time, and so its generated pom currently doesn't mention them at all. It does however depend on the management plugins at runtime. We should add the broker plugins as runtime dependencies in the broker pom, with the optional bdbstore modules listed as optional as optional dependencies.

      Most of the broker-plugins use 'provided' scope for the broker dependencies for historical reasons relating to their previous osgification (shipping certain deps at the broker level and exporting them, plus needing to place them in a completely different location from the core broker jars). The optional bdbstore module does not, but it would be useful if it aligned with the others and indeed would be good to ensure the optional [non-Apache Licence] BDB JE dependency must be added explicitly in the users pom in addition to the conscious choice to explicitly add the bdbstore module itself in general.

        Activity

        Robbie Gemmell made changes -
        Description The broker module does not strictly depend on the broker-plugins, and so its generated pom currently doesn't mention them at all. It would be useful for users however if we drew attention to and made gathering dependency info for the plugins easier by simply adding them as optional dependencies in the broker pom.

        Most of thehe broker-plugins use 'provided' scope for the broker dependencies for historical reasons relating to their previous osgification (shipping certain deps at the broker level and exporting them, plus needing to place them in a completely different location from the core broker jars). The optional bdbstore module does not, so it would be useful if it aligned with the others and is indeed would be good to ensure the optional JE dependency must be added explicitly in the user pom in addition to the conscious choice to explicitly add the bdbstore module itself in general.
        The broker module does not depend on the broker-plugins at compile time, and so its generated pom currently doesn't mention them at all. It does however depend on the management plugins at runtime. We should add the broker plugins as runtime dependencies in the broker pom, with the optional bdbstore modules listed as optional as optional dependencies.

        Most of the broker-plugins use 'provided' scope for the broker dependencies for historical reasons relating to their previous osgification (shipping certain deps at the broker level and exporting them, plus needing to place them in a completely different location from the core broker jars). The optional bdbstore module does not, but it would be useful if it aligned with the others and indeed would be good to ensure the optional [non-Apache Licence] BDB JE dependency must be added explicitly in the users pom in addition to the conscious choice to explicitly add the bdbstore module itself in general.
        Robbie Gemmell made changes -
        Summary [Java broker] add plugins as optional dependencies in the broker pom, and make the optional bdbstore module dep scopes in line with other plugins [Java broker] add plugins as runtime dependencies in the broker pom, and make the optional bdbstore module dep scopes in line with other plugins
        Robbie Gemmell made changes -
        Status Ready To Review [ 10006 ] Resolved [ 5 ]
        Assignee Keith Wall [ k-wall ] Robbie Gemmell [ gemmellr ]
        Resolution Fixed [ 1 ]
        Robbie Gemmell made changes -
        Assignee Alex Rudyy [ alex.rufous ] Keith Wall [ k-wall ]
        Robbie Gemmell made changes -
        Assignee Robbie Gemmell [ gemmellr ] Alex Rudyy [ alex.rufous ]
        Robbie Gemmell made changes -
        Status In Progress [ 3 ] Ready To Review [ 10006 ]
        Robbie Gemmell made changes -
        Field Original Value New Value
        Status Open [ 1 ] In Progress [ 3 ]
        Robbie Gemmell created issue -

          People

          • Assignee:
            Robbie Gemmell
            Reporter:
            Robbie Gemmell
          • Votes:
            0 Vote for this issue
            Watchers:
            1 Start watching this issue

            Dates

            • Created:
              Updated:
              Resolved:

              Development