Qpid
  1. Qpid
  2. QPID-4645

[Java broker] add plugins as runtime dependencies in the broker pom, and make the optional bdbstore module dep scopes in line with other plugins

    Details

    • Type: Improvement Improvement
    • Status: Closed
    • Priority: Major Major
    • Resolution: Fixed
    • Affects Version/s: None
    • Fix Version/s: 0.21
    • Component/s: Java Broker
    • Labels:
      None

      Description

      The broker module does not depend on the broker-plugins at compile time, and so its generated pom currently doesn't mention them at all. It does however depend on the management plugins at runtime. We should add the broker plugins as runtime dependencies in the broker pom, with the optional bdbstore modules listed as optional as optional dependencies.

      Most of the broker-plugins use 'provided' scope for the broker dependencies for historical reasons relating to their previous osgification (shipping certain deps at the broker level and exporting them, plus needing to place them in a completely different location from the core broker jars). The optional bdbstore module does not, but it would be useful if it aligned with the others and indeed would be good to ensure the optional [non-Apache Licence] BDB JE dependency must be added explicitly in the users pom in addition to the conscious choice to explicitly add the bdbstore module itself in general.

        Activity

        Hide
        Robbie Gemmell added a comment -

        Alex, could you take a look at this change please?

        Thanks,
        Robbie

        Show
        Robbie Gemmell added a comment - Alex, could you take a look at this change please? Thanks, Robbie
        Hide
        Robbie Gemmell added a comment -

        Actually....

        Keith, since you are working in this area just now anyway, can you review?

        Show
        Robbie Gemmell added a comment - Actually.... Keith, since you are working in this area just now anyway, can you review?
        Hide
        Robbie Gemmell added a comment -

        Just resolving.

        Show
        Robbie Gemmell added a comment - Just resolving.
        Hide
        Robbie Gemmell added a comment -

        Updated to change the plugins to runtime dependencies of the broker pom, leaving only the bdbstore related modules as optional: http://svn.apache.org/r1479178

        Change merged to 0.22 release branch in: http://svn.apache.org/r1479191

        Show
        Robbie Gemmell added a comment - Updated to change the plugins to runtime dependencies of the broker pom, leaving only the bdbstore related modules as optional: http://svn.apache.org/r1479178 Change merged to 0.22 release branch in: http://svn.apache.org/r1479191

          People

          • Assignee:
            Robbie Gemmell
            Reporter:
            Robbie Gemmell
          • Votes:
            0 Vote for this issue
            Watchers:
            1 Start watching this issue

            Dates

            • Created:
              Updated:
              Resolved:

              Development