Details

    • Type: Improvement Improvement
    • Status: Closed
    • Priority: Major Major
    • Resolution: Fixed
    • Affects Version/s: M2.1
    • Fix Version/s: 0.15
    • Component/s: Java Broker
    • Labels:
      None

      Description

      Firstly need to define Exception handling policies and apply consistently, then need to look at specific resolution for the two linked JIRAs too.

      The Java broker does not define or implement any form of consistent exception handling. In particular unrecoverable erros are at best handled by logging and then attempting to carry on regardless.

      I would argue that such errors should be followed by an immediate System.exit ... however others may wish this to be configurable.

        Issue Links

          Activity

          Rob Godfrey created issue -
          Rob Godfrey made changes -
          Field Original Value New Value
          Link This issue incorporates QPID-396 [ QPID-396 ]
          Martin Ritchie made changes -
          Fix Version/s M3 [ 12312117 ]
          Marnie McCormack made changes -
          Link This issue incorporates QPID-579 [ QPID-579 ]
          Marnie McCormack made changes -
          Description The Java broker does not define or implement ay form of consitant exception handling. In particular unrecoverable erros are at best handled by logging and then attempting to carry on regardless.

          I would argue that such errors should be followed by an immediate System.exit ... however others may wish this to be configurable.
          Firstly need to define Exception handling policies and apply consistently, then need to look at specific resolution for the two linked JIRAs too.

          The Java broker does not define or implement any form of consistent exception handling. In particular unrecoverable erros are at best handled by logging and then attempting to carry on regardless.

          I would argue that such errors should be followed by an immediate System.exit ... however others may wish this to be configurable.
          Affects Version/s M2.1 [ 12312720 ]
          Summary Define Exception handling policies and apply consistantly Fix Broker Exception Handling
          Assignee Aidan Skinner [ aidan ]
          Gavin made changes -
          Workflow jira [ 12402274 ] QPid [ 12437929 ]
          Gavin made changes -
          Workflow QPid [ 12437929 ] QPid Workflow [ 12439376 ]
          Aidan Skinner made changes -
          Fix Version/s M4 [ 12313279 ]
          Fix Version/s M3 [ 12312117 ]
          Hide
          Marnie McCormack added a comment -

          Moving items not being worked on afaik out of M4 Fix Version

          Show
          Marnie McCormack added a comment - Moving items not being worked on afaik out of M4 Fix Version
          Marnie McCormack made changes -
          Fix Version/s M4 [ 12313279 ]
          Hide
          Aidan Skinner added a comment -

          Bagsie not it

          Show
          Aidan Skinner added a comment - Bagsie not it
          Aidan Skinner made changes -
          Assignee Aidan Skinner [ aidan ]
          Rob Godfrey made changes -
          Assignee Rob Godfrey [ rgodfrey ]
          Rob Godfrey made changes -
          Status Open [ 1 ] In Progress [ 3 ]
          Rob Godfrey made changes -
          Status In Progress [ 3 ] Ready To Review [ 10006 ]
          Hide
          Keith Wall added a comment -

          I think the new uncaught exception handler should also try to log the exception to the Broker log file (using log4j) in addition to stderr. I say this as a) our users are already accustomed to checking this log file b) stderr many be swallowed by job control system or lost through careless redirection.

          Show
          Keith Wall added a comment - I think the new uncaught exception handler should also try to log the exception to the Broker log file (using log4j) in addition to stderr. I say this as a) our users are already accustomed to checking this log file b) stderr many be swallowed by job control system or lost through careless redirection.
          Hide
          Rob Godfrey added a comment -

          Robbie can you review this please

          Show
          Rob Godfrey added a comment - Robbie can you review this please
          Rob Godfrey made changes -
          Assignee Rob Godfrey [ rgodfrey ] Robbie Gemmell [ gemmellr ]
          Hide
          Robbie Gemmell added a comment -

          Looks good to me.

          Show
          Robbie Gemmell added a comment - Looks good to me.
          Robbie Gemmell made changes -
          Status Ready To Review [ 10006 ] Resolved [ 5 ]
          Fix Version/s 0.15 [ 12319043 ]
          Resolution Fixed [ 1 ]
          Rob Godfrey made changes -
          Status Resolved [ 5 ] Closed [ 6 ]
          Transition Time In Source Status Execution Times Last Executer Last Execution Date
          Open Open In Progress In Progress
          1719d 2h 14m 1 Rob Godfrey 03/Jan/12 11:34
          In Progress In Progress Reviewable Reviewable
          3s 1 Rob Godfrey 03/Jan/12 11:34
          Reviewable Reviewable Resolved Resolved
          48d 9h 14m 1 Robbie Gemmell 20/Feb/12 20:49
          Resolved Resolved Closed Closed
          1086d 23h 17m 1 Rob Godfrey 11/Feb/15 20:07

            People

            • Assignee:
              Robbie Gemmell
              Reporter:
              Rob Godfrey
            • Votes:
              0 Vote for this issue
              Watchers:
              0 Start watching this issue

              Dates

              • Created:
                Updated:
                Resolved:

                Development