Uploaded image for project: 'Qpid'
  1. Qpid
  2. QPID-4609

Incorrect lock in the synchronize statement in org.apache.qpid.server.model.adapter.BrokerAdapter

    Details

    • Type: Bug
    • Status: Closed
    • Priority: Minor
    • Resolution: Fixed
    • Affects Version/s: 0.21
    • Fix Version/s: 0.21
    • Component/s: Broker-J
    • Labels:
      None

      Description

      The getTrustStores() and getKeyStores() methods of the BrokerAdapter class seem use both the _trustStores object as a lock for the sychronize statement:

      @Override
      public Collection<KeyStore> getKeyStores()
      {
      synchronized(_trustStores)

      { return Collections.unmodifiableCollection(_keyStores.values()); }

      }

      @Override
      public Collection<TrustStore> getTrustStores()
      {
      synchronized(_trustStores)

      { return Collections.unmodifiableCollection(_trustStores.values()); }

      }

      Is that a bug? I would assume that the getKeyStores method should use the _keyStores object instead of _trustStores.

        Attachments

          Activity

            People

            • Assignee:
              gemmellr Robbie Gemmell
              Reporter:
              scholzj Jakub Scholz
            • Votes:
              0 Vote for this issue
              Watchers:
              3 Start watching this issue

              Dates

              • Created:
                Updated:
                Resolved: