Qpid
  1. Qpid
  2. QPID-4519

[Java broker] Virtualhost JMX MBean StatusEnabled attribute has the wrong value, and checking it should not cause an update

    Details

    • Type: Bug Bug
    • Status: Closed
    • Priority: Major Major
    • Resolution: Fixed
    • Affects Version/s: 0.18, 0.20
    • Fix Version/s: 0.20
    • Component/s: Java Broker
    • Labels:
      None

      Description

      The VirtualHost JMX MBean is currently returning false for isStatusEnabled; it should be true as the feature is now always enabled (the attribute was only maintained for compatibility). More of an issue however is that checking the value prompts a stats update to occur, which it should not.

        Activity

        Robbie Gemmell created issue -
        Robbie Gemmell made changes -
        Field Original Value New Value
        Status Open [ 1 ] In Progress [ 3 ]
        Robbie Gemmell made changes -
        Status In Progress [ 3 ] Ready To Review [ 10006 ]
        Hide
        Robbie Gemmell added a comment -

        Fix committed in http://svn.apache.org/viewvc?rev=1424763&view=rev

        Alex, can you review this change please? I would like to request it for 0.20 if there is time, given that it is a highly isolated and rather trivial change.

        Show
        Robbie Gemmell added a comment - Fix committed in http://svn.apache.org/viewvc?rev=1424763&view=rev Alex, can you review this change please? I would like to request it for 0.20 if there is time, given that it is a highly isolated and rather trivial change.
        Robbie Gemmell made changes -
        Assignee Robbie Gemmell [ gemmellr ] Alex Rudyy [ alex.rufous ]
        Hide
        Alex Rudyy added a comment -

        The change looks good for me.

        As it is trivial, it will be safe to include it into 0.20 release.

        Show
        Alex Rudyy added a comment - The change looks good for me. As it is trivial, it will be safe to include it into 0.20 release.
        Alex Rudyy made changes -
        Status Ready To Review [ 10006 ] Resolved [ 5 ]
        Resolution Fixed [ 1 ]
        Hide
        Justin Ross added a comment -

        Reviewed by Alex. Approved for 0.20.

        Show
        Justin Ross added a comment - Reviewed by Alex. Approved for 0.20.
        Robbie Gemmell made changes -
        Fix Version/s 0.20 [ 12323548 ]
        Fix Version/s 0.21 [ 12323549 ]
        Hide
        Robbie Gemmell added a comment -

        Now merged to the 0.20 release branch.

        Show
        Robbie Gemmell added a comment - Now merged to the 0.20 release branch.
        Rob Godfrey made changes -
        Status Resolved [ 5 ] Closed [ 6 ]
        Transition Time In Source Status Execution Times Last Executer Last Execution Date
        Open Open In Progress In Progress
        6m 37s 1 Robbie Gemmell 20/Dec/12 23:45
        In Progress In Progress Reviewable Reviewable
        3s 1 Robbie Gemmell 20/Dec/12 23:45
        Reviewable Reviewable Resolved Resolved
        9m 6s 1 Alex Rudyy 20/Dec/12 23:55
        Resolved Resolved Closed Closed
        782d 20h 11m 1 Rob Godfrey 11/Feb/15 20:06

          People

          • Assignee:
            Alex Rudyy
            Reporter:
            Robbie Gemmell
          • Votes:
            0 Vote for this issue
            Watchers:
            3 Start watching this issue

            Dates

            • Created:
              Updated:
              Resolved:

              Development