Qpid
  1. Qpid
  2. QPID-4513

[Java Client] can erroneously log "Unable to load custom SASL providers." when loaded with multiple class loaders

    Details

    • Type: Bug Bug
    • Status: Closed
    • Priority: Major Major
    • Resolution: Fixed
    • Affects Version/s: 0.18, 0.20
    • Fix Version/s: 0.21
    • Component/s: Java Client
    • Labels:
      None

      Description

      An ERROR log "Unable to load custom SASL providers." is produced by the java client when CallbackHandlerRegistry is loaded by multiple class loaders. In this case the first class loader successfully registers the SASL providers on opening of the first connection and uses of other class loaders causes the error message because they are enable to register SASL providers because they are already registered.

      The registration process should be updated to detect that all required providers are already registered and only log an error if they are not.

        Activity

        Alex Rudyy created issue -
        Hide
        Alex Rudyy added a comment -

        Attached a patch fixing the issue

        Show
        Alex Rudyy added a comment - Attached a patch fixing the issue
        Alex Rudyy made changes -
        Field Original Value New Value
        Attachment 0001-QPID-4513-Add-check-to-detect-registered-SASL-provid.patch [ 12561710 ]
        Hide
        Robbie Gemmell added a comment -

        Attaching a noddy utility class used to load the relvant client classes in multiple classloaders and provoke multiple registration attempts. Used as an additional check beyond the new tests to verify the issue and effectiveness of the changes being made.

        Show
        Robbie Gemmell added a comment - Attaching a noddy utility class used to load the relvant client classes in multiple classloaders and provoke multiple registration attempts. Used as an additional check beyond the new tests to verify the issue and effectiveness of the changes being made.
        Robbie Gemmell made changes -
        Attachment MyClassLoader.java [ 12561907 ]
        Robbie Gemmell made changes -
        Assignee Robbie Gemmell [ gemmellr ]
        Robbie Gemmell made changes -
        Status Open [ 1 ] In Progress [ 3 ]
        Hide
        Robbie Gemmell added a comment -

        Attaching updated patch by myself and Alex, as is about to be committed.

        Show
        Robbie Gemmell added a comment - Attaching updated patch by myself and Alex, as is about to be committed.
        Robbie Gemmell made changes -
        Robbie Gemmell made changes -
        Fix Version/s 0.21 [ 12323549 ]
        Robbie Gemmell made changes -
        Status In Progress [ 3 ] Ready To Review [ 10006 ]
        Hide
        Robbie Gemmell added a comment -

        Alex, can you click the button please

        Show
        Robbie Gemmell added a comment - Alex, can you click the button please
        Robbie Gemmell made changes -
        Assignee Robbie Gemmell [ gemmellr ] Alex Rudyy [ alex.rufous ]
        Hide
        Alex Rudyy added a comment -

        The committed changes look good for me. Reviewed with no comments.

        Show
        Alex Rudyy added a comment - The committed changes look good for me. Reviewed with no comments.
        Alex Rudyy made changes -
        Status Ready To Review [ 10006 ] Resolved [ 5 ]
        Resolution Fixed [ 1 ]
        Alex Rudyy made changes -
        Status Resolved [ 5 ] Closed [ 6 ]
        Transition Time In Source Status Execution Times Last Executer Last Execution Date
        Open Open In Progress In Progress
        1d 33m 1 Robbie Gemmell 20/Dec/12 15:48
        In Progress In Progress Reviewable Reviewable
        19m 24s 1 Robbie Gemmell 20/Dec/12 16:07
        Reviewable Reviewable Resolved Resolved
        7h 32m 1 Alex Rudyy 20/Dec/12 23:40
        Resolved Resolved Closed Closed
        14s 1 Alex Rudyy 20/Dec/12 23:40

          People

          • Assignee:
            Alex Rudyy
            Reporter:
            Alex Rudyy
          • Votes:
            0 Vote for this issue
            Watchers:
            2 Start watching this issue

            Dates

            • Created:
              Updated:
              Resolved:

              Development