Qpid
  1. Qpid
  2. QPID-4476

[Java broker] SimpleLDAPAuthenticationManager returns different Principal name formats for sasl vs non-sasl usage

    Details

    • Type: Bug Bug
    • Status: Resolved
    • Priority: Major Major
    • Resolution: Fixed
    • Affects Version/s: 0.18, 0.20
    • Fix Version/s: 0.20, 0.21
    • Component/s: Java Broker
    • Labels:
      None

      Description

      The SimpleLDAPAuthenticationManager returns different Principal name formats for sasl vs non-sasl usage.

      In the sasl case, the PlainSaslServer returns the basic username that was originally provided, but in the non-sasl case the SimpleLDAPAuthenticationManager returns a Principal based on the search context/filter. This leads to inconsistent behaviour between e.g. AMQP and JMX interface authentication, and in the later case means it is not possible to specify the user be included as part of an group.

      The non-sasl behaviour should be updated to be consistent with the sasl behaviour.

        Activity

        Robbie Gemmell created issue -
        Robbie Gemmell made changes -
        Field Original Value New Value
        Assignee Robbie Gemmell [ gemmellr ]
        Robbie Gemmell made changes -
        Status Open [ 1 ] In Progress [ 3 ]
        Robbie Gemmell made changes -
        Status In Progress [ 3 ] Ready To Review [ 10006 ]
        Hide
        Robbie Gemmell added a comment -
        Show
        Robbie Gemmell added a comment - Change made in http://svn.apache.org/viewvc?rev=1414257&view=rev
        Hide
        Robbie Gemmell added a comment -

        Rob, could you review this please?

        Show
        Robbie Gemmell added a comment - Rob, could you review this please?
        Robbie Gemmell made changes -
        Assignee Robbie Gemmell [ gemmellr ] Rob Godfrey [ rgodfrey ]
        Hide
        Rob Godfrey added a comment -

        Looks good

        Show
        Rob Godfrey added a comment - Looks good
        Rob Godfrey made changes -
        Status Ready To Review [ 10006 ] Resolved [ 5 ]
        Resolution Fixed [ 1 ]
        Hide
        Justin Ross added a comment -

        Reviewed by Rob. Approved for 0.20.

        Show
        Justin Ross added a comment - Reviewed by Rob. Approved for 0.20.
        Justin Ross made changes -
        Fix Version/s 0.20 [ 12323548 ]
        Hide
        Robbie Gemmell added a comment -

        Now merged to the 0.20 release branch.

        Show
        Robbie Gemmell added a comment - Now merged to the 0.20 release branch.

          People

          • Assignee:
            Rob Godfrey
            Reporter:
            Robbie Gemmell
          • Votes:
            0 Vote for this issue
            Watchers:
            3 Start watching this issue

            Dates

            • Created:
              Updated:
              Resolved:

              Development