Qpid
  1. Qpid
  2. QPID-4472

NPE when connecting over AMQP 1.0 with no SASL layer

    Details

    • Type: Bug Bug
    • Status: Closed
    • Priority: Major Major
    • Resolution: Fixed
    • Affects Version/s: 0.20
    • Fix Version/s: 0.20, 0.21
    • Component/s: Java Broker
    • Labels:
      None

      Description

      In doing some interop testing, I ran the c++ client (qpid::messaging) against the java broker without a SASL layer, triggering a NullPointerException and broker shutdown:

      [Broker] BRK-1004 : Qpid Broker Ready
      java.lang.NullPointerException
      	at org.apache.qpid.server.protocol.ProtocolEngine_1_0_0.received(ProtocolEngine_1_0_0.java:280)
      	at org.apache.qpid.server.protocol.ProtocolEngine_1_0_0.received(ProtocolEngine_1_0_0.java:49)
      	at org.apache.qpid.server.protocol.MultiVersionProtocolEngine$SelfDelegateProtocolEngine.received(MultiVersionProtocolEngine.java:556)
      	at org.apache.qpid.server.protocol.MultiVersionProtocolEngine$SelfDelegateProtocolEngine.received(MultiVersionProtocolEngine.java:442)
      	at org.apache.qpid.server.protocol.MultiVersionProtocolEngine.received(MultiVersionProtocolEngine.java:118)
      	at org.apache.qpid.server.protocol.MultiVersionProtocolEngine.received(MultiVersionProtocolEngine.java:37)
      	at org.apache.qpid.transport.network.io.IoReceiver.run(IoReceiver.java:161)
      	at java.lang.Thread.run(Thread.java:722)
      ########################################################################
      #
      # Unhandled Exception java.lang.NullPointerException in Thread IoReceiver - /127.0.0.1:59542
      #
      # Exiting
      #
      ########################################################################
      java.lang.NullPointerException
      	at org.apache.qpid.server.protocol.ProtocolEngine_1_0_0.closed(ProtocolEngine_1_0_0.java:293)
      	at org.apache.qpid.server.protocol.MultiVersionProtocolEngine.closed(MultiVersionProtocolEngine.java:102)
      	at org.apache.qpid.transport.network.io.IoReceiver.run(IoReceiver.java:222)
      	at java.lang.Thread.run(Thread.java:722)
      

        Activity

        Hide
        Rob Godfrey added a comment -

        I've made a change to the Non-SASL AMQP 1.0 code which will hopefully address this issue

        Let me know if you continue to see problems

        Show
        Rob Godfrey added a comment - I've made a change to the Non-SASL AMQP 1.0 code which will hopefully address this issue Let me know if you continue to see problems
        Hide
        Gordon Sim added a comment -

        That certainly seems to prevent the NPE.

        Show
        Gordon Sim added a comment - That certainly seems to prevent the NPE.
        Hide
        Justin Ross added a comment -

        Approved for 0.20.

        Show
        Justin Ross added a comment - Approved for 0.20.
        Hide
        Rob Godfrey added a comment -

        Merged to 0.20 as r1414799.

        Show
        Rob Godfrey added a comment - Merged to 0.20 as r1414799.

          People

          • Assignee:
            Rob Godfrey
            Reporter:
            Gordon Sim
          • Votes:
            0 Vote for this issue
            Watchers:
            3 Start watching this issue

            Dates

            • Created:
              Updated:
              Resolved:

              Development