Qpid
  1. Qpid
  2. QPID-4469

[Java common] remove unused sslContext parameter from OutgoingNetworkTransport#connect()

    Details

    • Type: Improvement Improvement
    • Status: Resolved
    • Priority: Major Major
    • Resolution: Fixed
    • Affects Version/s: 0.14, 0.16, 0.18
    • Fix Version/s: 0.20, 0.21
    • Component/s: Java Client, Java Common
    • Labels:
      None

      Description

      OutgoingNetworkTransport#connect() takes an sslContext parameter. This is unused by the transport implementations because SSL is implemented in the client as a wrapper over the transport. The 0-10 path of the client supplies null for this arg, but the 08/0-9/0-9-1 patch still creates and supplies one. The parameter should be removed to ensure consistency now and in the future.

        Activity

        Robbie Gemmell created issue -
        Robbie Gemmell made changes -
        Field Original Value New Value
        Status Open [ 1 ] In Progress [ 3 ]
        Robbie Gemmell made changes -
        Status In Progress [ 3 ] Ready To Review [ 10006 ]
        Robbie Gemmell made changes -
        Assignee Robbie Gemmell [ gemmellr ] Rob Godfrey [ rgodfrey ]
        Justin Ross made changes -
        Fix Version/s 0.20 [ 12323548 ]
        Robbie Gemmell made changes -
        Status Ready To Review [ 10006 ] Resolved [ 5 ]
        Resolution Fixed [ 1 ]

          People

          • Assignee:
            Rob Godfrey
            Reporter:
            Robbie Gemmell
          • Votes:
            0 Vote for this issue
            Watchers:
            2 Start watching this issue

            Dates

            • Created:
              Updated:
              Resolved:

              Development