Qpid
  1. Qpid
  2. QPID-4469

[Java common] remove unused sslContext parameter from OutgoingNetworkTransport#connect()

    Details

    • Type: Improvement Improvement
    • Status: Resolved
    • Priority: Major Major
    • Resolution: Fixed
    • Affects Version/s: 0.14, 0.16, 0.18
    • Fix Version/s: 0.20, 0.21
    • Component/s: Java Client, Java Common
    • Labels:
      None

      Description

      OutgoingNetworkTransport#connect() takes an sslContext parameter. This is unused by the transport implementations because SSL is implemented in the client as a wrapper over the transport. The 0-10 path of the client supplies null for this arg, but the 08/0-9/0-9-1 patch still creates and supplies one. The parameter should be removed to ensure consistency now and in the future.

        Activity

        Hide
        Robbie Gemmell added a comment -
        Show
        Robbie Gemmell added a comment - Change made in http://svn.apache.org/viewvc?rev=1413363&view=rev
        Hide
        Robbie Gemmell added a comment -

        Rob reviewed this together with the changes for QPID-4468 (and 'thanked' me via email me for conflicting heavily with his changes for QPID-2796 )

        Show
        Robbie Gemmell added a comment - Rob reviewed this together with the changes for QPID-4468 (and 'thanked' me via email me for conflicting heavily with his changes for QPID-2796 )
        Hide
        Justin Ross added a comment -

        Though not in itself a priority change for 0.20, it sensibly goes along with QPID-4468. Reviewed by Rob. Approved for 0.20.

        Show
        Justin Ross added a comment - Though not in itself a priority change for 0.20, it sensibly goes along with QPID-4468 . Reviewed by Rob. Approved for 0.20.
        Hide
        Robbie Gemmell added a comment -

        Now merged to the 0.20 release branch.

        Show
        Robbie Gemmell added a comment - Now merged to the 0.20 release branch.

          People

          • Assignee:
            Rob Godfrey
            Reporter:
            Robbie Gemmell
          • Votes:
            0 Vote for this issue
            Watchers:
            2 Start watching this issue

            Dates

            • Created:
              Updated:
              Resolved:

              Development