Uploaded image for project: 'Qpid'
  1. Qpid
  2. QPID-4458

tidy up the gentools directory and move it into the java tree

    Details

    • Type: Task
    • Status: Closed
    • Priority: Major
    • Resolution: Fixed
    • Affects Version/s: None
    • Fix Version/s: 0.21
    • Component/s: None
    • Labels:
      None

      Description

      The gentools directory has two jar files in it for velocity and velocity-dep, as well as a lot of apparently unused template files. Gentools only seem to be legitimately referenced from within the Java modules so it should be tidied up and moved into the Java tree, with use of Ivy to retrieve the dependencies.

        Activity

        Hide
        jira-bot ASF subversion and git services added a comment -

        Commit 1539622 from Justin Ross in branch 'qpid/trunk'
        [ https://svn.apache.org/r1539622 ]

        QPID-4458: Remove unused qpid/gentools subtree

        Show
        jira-bot ASF subversion and git services added a comment - Commit 1539622 from Justin Ross in branch 'qpid/trunk' [ https://svn.apache.org/r1539622 ] QPID-4458 : Remove unused qpid/gentools subtree
        Hide
        justi9 Justin Ross added a comment -

        Cool, thanks!

        Show
        justi9 Justin Ross added a comment - Cool, thanks!
        Hide
        gemmellr Robbie Gemmell added a comment -

        Oops. That is an artifact of my use of git-svn, it doesn't remove newly-empty svn directories (because git doesn't actually version directories at all, only files) unless you explicitly tell it to, and I obviously forgot at the time, I don't have a problem with its removal.

        Show
        gemmellr Robbie Gemmell added a comment - Oops. That is an artifact of my use of git-svn, it doesn't remove newly-empty svn directories (because git doesn't actually version directories at all, only files) unless you explicitly tell it to, and I obviously forgot at the time, I don't have a problem with its removal.
        Hide
        justi9 Justin Ross added a comment -

        Any possible issues with me removing the top-level qpid/gentools tree? AFAICT, it has no content now.

        Show
        justi9 Justin Ross added a comment - Any possible issues with me removing the top-level qpid/gentools tree? AFAICT, it has no content now.
        Hide
        gemmellr Robbie Gemmell added a comment -

        Resolving, update was applied and has been in use for months.

        Show
        gemmellr Robbie Gemmell added a comment - Resolving, update was applied and has been in use for months.
        Hide
        gemmellr Robbie Gemmell added a comment -

        Attaching updated patch.

        Integrates gentools into the common module build process and removes its standalone build file. Compiles the gentools classes into the build/scatch area instead of into its src dir as it has previously. Removes the unused cpp/src/generate.sh script that referenced gentools.

        Show
        gemmellr Robbie Gemmell added a comment - Attaching updated patch. Integrates gentools into the common module build process and removes its standalone build file. Compiles the gentools classes into the build/scatch area instead of into its src dir as it has previously. Removes the unused cpp/src/generate.sh script that referenced gentools.
        Hide
        gemmellr Robbie Gemmell added a comment -

        Attaching WIP patch, which makes some more extensive changes than previously:

        Removes some apparently unused templates and xml files from gentools dir and then moves the remainder to java/common/gentools. Retrieves the velocity dependencies using Ivy. Removes unused java/common/protocol-version.xml file.

        Show
        gemmellr Robbie Gemmell added a comment - Attaching WIP patch, which makes some more extensive changes than previously: Removes some apparently unused templates and xml files from gentools dir and then moves the remainder to java/common/gentools. Retrieves the velocity dependencies using Ivy. Removes unused java/common/protocol-version.xml file.
        Hide
        gemmellr Robbie Gemmell added a comment -

        Reopening, I reverted the prior change as a CI build failure after a clean checkout showed they need more work.

        Show
        gemmellr Robbie Gemmell added a comment - Reopening, I reverted the prior change as a CI build failure after a clean checkout showed they need more work.
        Hide
        rgodfrey Rob Godfrey added a comment -

        Looks good

        Show
        rgodfrey Rob Godfrey added a comment - Looks good
        Hide
        gemmellr Robbie Gemmell added a comment -

        Rob, could you review this change please?

        Thanks,
        Robbie

        Show
        gemmellr Robbie Gemmell added a comment - Rob, could you review this change please? Thanks, Robbie
        Hide
        gemmellr Robbie Gemmell added a comment -
        Show
        gemmellr Robbie Gemmell added a comment - Change made at: http://svn.apache.org/viewvc?rev=1412380&view=rev

          People

          • Assignee:
            gemmellr Robbie Gemmell
            Reporter:
            gemmellr Robbie Gemmell
          • Votes:
            0 Vote for this issue
            Watchers:
            4 Start watching this issue

            Dates

            • Created:
              Updated:
              Resolved:

              Development