Qpid
  1. Qpid
  2. QPID-4458

tidy up the gentools directory and move it into the java tree

    Details

    • Type: Task Task
    • Status: Resolved
    • Priority: Major Major
    • Resolution: Fixed
    • Affects Version/s: None
    • Fix Version/s: 0.21
    • Component/s: None
    • Labels:
      None

      Description

      The gentools directory has two jar files in it for velocity and velocity-dep, as well as a lot of apparently unused template files. Gentools only seem to be legitimately referenced from within the Java modules so it should be tidied up and moved into the Java tree, with use of Ivy to retrieve the dependencies.

        Activity

        Robbie Gemmell created issue -
        Robbie Gemmell made changes -
        Field Original Value New Value
        Assignee Robbie Gemmell [ gemmellr ]
        Robbie Gemmell made changes -
        Status Open [ 1 ] In Progress [ 3 ]
        Hide
        Robbie Gemmell added a comment -
        Show
        Robbie Gemmell added a comment - Change made at: http://svn.apache.org/viewvc?rev=1412380&view=rev
        Robbie Gemmell made changes -
        Status In Progress [ 3 ] Ready To Review [ 10006 ]
        Hide
        Robbie Gemmell added a comment -

        Rob, could you review this change please?

        Thanks,
        Robbie

        Show
        Robbie Gemmell added a comment - Rob, could you review this change please? Thanks, Robbie
        Robbie Gemmell made changes -
        Assignee Robbie Gemmell [ gemmellr ] Rob Godfrey [ rgodfrey ]
        Hide
        Rob Godfrey added a comment -

        Looks good

        Show
        Rob Godfrey added a comment - Looks good
        Rob Godfrey made changes -
        Status Ready To Review [ 10006 ] Resolved [ 5 ]
        Resolution Fixed [ 1 ]
        Hide
        Robbie Gemmell added a comment -

        Reopening, I reverted the prior change as a CI build failure after a clean checkout showed they need more work.

        Show
        Robbie Gemmell added a comment - Reopening, I reverted the prior change as a CI build failure after a clean checkout showed they need more work.
        Robbie Gemmell made changes -
        Resolution Fixed [ 1 ]
        Status Resolved [ 5 ] Reopened [ 4 ]
        Assignee Rob Godfrey [ rgodfrey ] Robbie Gemmell [ gemmellr ]
        Robbie Gemmell made changes -
        Status Reopened [ 4 ] In Progress [ 3 ]
        Hide
        Robbie Gemmell added a comment -

        Attaching WIP patch, which makes some more extensive changes than previously:

        Removes some apparently unused templates and xml files from gentools dir and then moves the remainder to java/common/gentools. Retrieves the velocity dependencies using Ivy. Removes unused java/common/protocol-version.xml file.

        Show
        Robbie Gemmell added a comment - Attaching WIP patch, which makes some more extensive changes than previously: Removes some apparently unused templates and xml files from gentools dir and then moves the remainder to java/common/gentools. Retrieves the velocity dependencies using Ivy. Removes unused java/common/protocol-version.xml file.
        Robbie Gemmell made changes -
        Hide
        Robbie Gemmell added a comment -

        Attaching updated patch.

        Integrates gentools into the common module build process and removes its standalone build file. Compiles the gentools classes into the build/scatch area instead of into its src dir as it has previously. Removes the unused cpp/src/generate.sh script that referenced gentools.

        Show
        Robbie Gemmell added a comment - Attaching updated patch. Integrates gentools into the common module build process and removes its standalone build file. Compiles the gentools classes into the build/scatch area instead of into its src dir as it has previously. Removes the unused cpp/src/generate.sh script that referenced gentools.
        Robbie Gemmell made changes -
        Robbie Gemmell made changes -
        Summary switch the velocity jar dependencies in gentools/lib to being retrieved with ivy tidy up the gentools directory and move it into the java tree
        Robbie Gemmell made changes -
        Description The gentools module has jar files in it for velocity and velocity-dep. These only seem to be referenced from within the Java modules and were missed when switching over the Java modules to use Ivy to retrieve their dependencies earlier in the year. These should be switched over to being retrieved with Ivy as well. The gentools directory has two jar files in it for velocity and velocity-dep, as well as a lot of apparently unused template files. Gentools only seem to be legitimately referenced from within the Java modules so it should be tidied up and moved into the Java tree, with use of Ivy to retrieve the dependencies.
        Hide
        Robbie Gemmell added a comment -

        Resolving, update was applied and has been in use for months.

        Show
        Robbie Gemmell added a comment - Resolving, update was applied and has been in use for months.
        Robbie Gemmell made changes -
        Status In Progress [ 3 ] Resolved [ 5 ]
        Resolution Fixed [ 1 ]
        Hide
        Justin Ross added a comment -

        Any possible issues with me removing the top-level qpid/gentools tree? AFAICT, it has no content now.

        Show
        Justin Ross added a comment - Any possible issues with me removing the top-level qpid/gentools tree? AFAICT, it has no content now.
        Hide
        Robbie Gemmell added a comment -

        Oops. That is an artifact of my use of git-svn, it doesn't remove newly-empty svn directories (because git doesn't actually version directories at all, only files) unless you explicitly tell it to, and I obviously forgot at the time, I don't have a problem with its removal.

        Show
        Robbie Gemmell added a comment - Oops. That is an artifact of my use of git-svn, it doesn't remove newly-empty svn directories (because git doesn't actually version directories at all, only files) unless you explicitly tell it to, and I obviously forgot at the time, I don't have a problem with its removal.
        Hide
        Justin Ross added a comment -

        Cool, thanks!

        Show
        Justin Ross added a comment - Cool, thanks!
        Hide
        ASF subversion and git services added a comment -

        Commit 1539622 from Justin Ross in branch 'qpid/trunk'
        [ https://svn.apache.org/r1539622 ]

        QPID-4458: Remove unused qpid/gentools subtree

        Show
        ASF subversion and git services added a comment - Commit 1539622 from Justin Ross in branch 'qpid/trunk' [ https://svn.apache.org/r1539622 ] QPID-4458 : Remove unused qpid/gentools subtree
        Transition Time In Source Status Execution Times Last Executer Last Execution Date
        Open Open In Progress In Progress
        24m 45s 1 Robbie Gemmell 22/Nov/12 00:14
        In Progress In Progress Reviewable Reviewable
        18h 38m 1 Robbie Gemmell 22/Nov/12 18:52
        Reviewable Reviewable Resolved Resolved
        13m 19s 1 Rob Godfrey 22/Nov/12 19:06
        Resolved Resolved Reopened Reopened
        5h 40m 1 Robbie Gemmell 23/Nov/12 00:47
        Reopened Reopened In Progress In Progress
        23d 22h 46m 1 Robbie Gemmell 16/Dec/12 23:33
        In Progress In Progress Resolved Resolved
        102d 10h 35m 1 Robbie Gemmell 29/Mar/13 10:08

          People

          • Assignee:
            Robbie Gemmell
            Reporter:
            Robbie Gemmell
          • Votes:
            0 Vote for this issue
            Watchers:
            4 Start watching this issue

            Dates

            • Created:
              Updated:
              Resolved:

              Development