Uploaded image for project: 'Qpid'
  1. Qpid
  2. QPID-4456

update the Java broker-only release package to account for changes in plugin system

    Details

    • Type: Task
    • Status: Closed
    • Priority: Blocker
    • Resolution: Fixed
    • Affects Version/s: 0.19
    • Fix Version/s: 0.20
    • Component/s: Packaging
    • Labels:
      None

      Description

      Following the simplification of the plugin system in the Java broker via QPID-4335 and the modifications to the tests in QPID-4353, the plugins are not being packaged in the broker-only release binary (as per discussion on QPID-4444 just prior to the 0.20 beta).

      The build system should be updated to account for the changes and ensure the plugins are again included.

        Activity

        Hide
        gemmellr Robbie Gemmell added a comment -
        Show
        gemmellr Robbie Gemmell added a comment - Changes made in: http://svn.apache.org/viewvc?rev=1412359&view=rev
        Hide
        gemmellr Robbie Gemmell added a comment -

        Rob, could you review this change please?

        Thanks,
        Robbie

        Show
        gemmellr Robbie Gemmell added a comment - Rob, could you review this change please? Thanks, Robbie
        Hide
        rgodfrey Rob Godfrey added a comment -

        Looks good to me

        Show
        rgodfrey Rob Godfrey added a comment - Looks good to me
        Hide
        gemmellr Robbie Gemmell added a comment -

        Reopening because I forgot to update the qpid-server.bat file for Windows to also pick up the plugins.

        Show
        gemmellr Robbie Gemmell added a comment - Reopening because I forgot to update the qpid-server.bat file for Windows to also pick up the plugins.
        Hide
        gemmellr Robbie Gemmell added a comment -

        Updated the windows script and the broker startup example in the documentation:
        http://svn.apache.org/viewvc?rev=1413444&view=rev

        Show
        gemmellr Robbie Gemmell added a comment - Updated the windows script and the broker startup example in the documentation: http://svn.apache.org/viewvc?rev=1413444&view=rev
        Hide
        gemmellr Robbie Gemmell added a comment -

        Hi Keith, could you review this change please?

        Show
        gemmellr Robbie Gemmell added a comment - Hi Keith, could you review this change please?
        Hide
        justi9 Justin Ross added a comment -

        The first change, from Robbie's initial comment, is reviewed by Rob and approved for 0.20.

        Show
        justi9 Justin Ross added a comment - The first change, from Robbie's initial comment, is reviewed by Rob and approved for 0.20.
        Hide
        k-wall Keith Wall added a comment -

        Changes look fine to me.

        Show
        k-wall Keith Wall added a comment - Changes look fine to me.
        Hide
        gemmellr Robbie Gemmell added a comment - - edited

        First change now merged to the 0.20 branch, second change requested for inclusion following review by Keith.

        Show
        gemmellr Robbie Gemmell added a comment - - edited First change now merged to the 0.20 branch, second change requested for inclusion following review by Keith.
        Hide
        justi9 Justin Ross added a comment -

        Second change reviewed by Keith; approved for 0.20.

        Show
        justi9 Justin Ross added a comment - Second change reviewed by Keith; approved for 0.20.
        Hide
        gemmellr Robbie Gemmell added a comment -

        Second commit now merged to the 0.20 release branch.

        Show
        gemmellr Robbie Gemmell added a comment - Second commit now merged to the 0.20 release branch.

          People

          • Assignee:
            k-wall Keith Wall
            Reporter:
            gemmellr Robbie Gemmell
          • Votes:
            0 Vote for this issue
            Watchers:
            4 Start watching this issue

            Dates

            • Created:
              Updated:
              Resolved:

              Development