Qpid
  1. Qpid
  2. QPID-4456

update the Java broker-only release package to account for changes in plugin system

    Details

    • Type: Task Task
    • Status: Closed
    • Priority: Blocker Blocker
    • Resolution: Fixed
    • Affects Version/s: 0.19
    • Fix Version/s: 0.20
    • Component/s: Packaging
    • Labels:
      None

      Description

      Following the simplification of the plugin system in the Java broker via QPID-4335 and the modifications to the tests in QPID-4353, the plugins are not being packaged in the broker-only release binary (as per discussion on QPID-4444 just prior to the 0.20 beta).

      The build system should be updated to account for the changes and ensure the plugins are again included.

        Activity

        Hide
        Robbie Gemmell added a comment -

        Second commit now merged to the 0.20 release branch.

        Show
        Robbie Gemmell added a comment - Second commit now merged to the 0.20 release branch.
        Hide
        Justin Ross added a comment -

        Second change reviewed by Keith; approved for 0.20.

        Show
        Justin Ross added a comment - Second change reviewed by Keith; approved for 0.20.
        Hide
        Robbie Gemmell added a comment - - edited

        First change now merged to the 0.20 branch, second change requested for inclusion following review by Keith.

        Show
        Robbie Gemmell added a comment - - edited First change now merged to the 0.20 branch, second change requested for inclusion following review by Keith.
        Hide
        Keith Wall added a comment -

        Changes look fine to me.

        Show
        Keith Wall added a comment - Changes look fine to me.
        Hide
        Justin Ross added a comment -

        The first change, from Robbie's initial comment, is reviewed by Rob and approved for 0.20.

        Show
        Justin Ross added a comment - The first change, from Robbie's initial comment, is reviewed by Rob and approved for 0.20.
        Hide
        Robbie Gemmell added a comment -

        Hi Keith, could you review this change please?

        Show
        Robbie Gemmell added a comment - Hi Keith, could you review this change please?
        Hide
        Robbie Gemmell added a comment -

        Updated the windows script and the broker startup example in the documentation:
        http://svn.apache.org/viewvc?rev=1413444&view=rev

        Show
        Robbie Gemmell added a comment - Updated the windows script and the broker startup example in the documentation: http://svn.apache.org/viewvc?rev=1413444&view=rev
        Hide
        Robbie Gemmell added a comment -

        Reopening because I forgot to update the qpid-server.bat file for Windows to also pick up the plugins.

        Show
        Robbie Gemmell added a comment - Reopening because I forgot to update the qpid-server.bat file for Windows to also pick up the plugins.
        Hide
        Rob Godfrey added a comment -

        Looks good to me

        Show
        Rob Godfrey added a comment - Looks good to me
        Hide
        Robbie Gemmell added a comment -

        Rob, could you review this change please?

        Thanks,
        Robbie

        Show
        Robbie Gemmell added a comment - Rob, could you review this change please? Thanks, Robbie
        Hide
        Robbie Gemmell added a comment -
        Show
        Robbie Gemmell added a comment - Changes made in: http://svn.apache.org/viewvc?rev=1412359&view=rev

          People

          • Assignee:
            Keith Wall
            Reporter:
            Robbie Gemmell
          • Votes:
            0 Vote for this issue
            Watchers:
            4 Start watching this issue

            Dates

            • Created:
              Updated:
              Resolved:

              Development