[QPID-4432] AMQStateManager logger might generate unexpected amount of logs during failover

• Type: Bug
• Status: Closed
• Priority: Minor
• Resolution: Fixed
• Affects Version/s: 0.6, 0.8, 0.10, 0.12, 0.14, 0.16, 0.18
• Fix Version/s: 0.21
• Component/s: JMS AMQP 0-x
• Assignee: Alex Rudyy
• Reporter: Alex Rudyy
• Created: 12/Nov/12 14:39
• Updated: 16/Jan/13 14:57
• Resolved: 16/Jan/13 14:57

Description

In certain situation during the failover the logging from AMQStateManager might generate massive logs:

for (StateWaiter waiter : _waiters)
{
    _logger.error("Notifying Waiters(" + _waiters + ") for error:" + error.getMessage());
    waiter.error(error);
}

1) the repeated logging of collection of all waiters for each of them is not really required
2) the log level should be debug, as we are logging the exception in callers with INFO log level
3) it looks like all logging from AMQStateManager should have a debug log level