Qpid
  1. Qpid
  2. QPID-4432

AMQStateManager logger might generate unexpected amount of logs during failover

    Details

    • Type: Bug Bug
    • Status: Closed
    • Priority: Minor Minor
    • Resolution: Fixed
    • Affects Version/s: 0.6, 0.8, 0.10, 0.12, 0.14, 0.16, 0.18
    • Fix Version/s: 0.21
    • Component/s: Java Client
    • Labels:
      None

      Description

      In certain situation during the failover the logging from AMQStateManager might generate massive logs:

      for (StateWaiter waiter : _waiters)
      {
          _logger.error("Notifying Waiters(" + _waiters + ") for error:" + error.getMessage());
          waiter.error(error);
      }
      

      1) the repeated logging of collection of all waiters for each of them is not really required
      2) the log level should be debug, as we are logging the exception in callers with INFO log level
      3) it looks like all logging from AMQStateManager should have a debug log level

        Activity

        Hide
        Keith Wall added a comment -

        Reviewed, no comments raised.

        Show
        Keith Wall added a comment - Reviewed, no comments raised.
        Hide
        Philip Harvey added a comment -

        Committed change in revision 1433911. Please can you review.

        Show
        Philip Harvey added a comment - Committed change in revision 1433911. Please can you review.

          People

          • Assignee:
            Alex Rudyy
            Reporter:
            Alex Rudyy
          • Votes:
            0 Vote for this issue
            Watchers:
            3 Start watching this issue

            Dates

            • Created:
              Updated:
              Resolved:

              Development