[QPID-4425] Possible incorrect error reporting "Error locking blob area for persistable item"

• Type: Bug
• Status: Closed
• Priority: Trivial
• Resolution: Auto Closed
• Affects Version/s: 0.18
• Component/s: C++ Broker

Environment

Windows

• Assignee: Stephen D. Huston
• Reporter: Alexey Sviridov
• Created: 07/Nov/12 03:56
• Updated: 14/Mar/18 20:27
• Resolved: 14/Mar/18 20:27

Description

In mssql_store module class BlobEncoder has incorrect error reporting.
In code bellow

BlobEncoder.cpp

    blob = SafeArrayCreate(VT_UI1, 1, bound);
    if (S_OK != SafeArrayLock(blob)) {
        SafeArrayDestroy(blob);
        blob = 0;
        throw qpid::Exception("Error locking blob area for persistable item");
    }

Exception "Error locking blob area for persistable item" hides possible error in SafeArrayCreate (which is more likely to be happen, cause SafeArrayCreate can fail on out of memory)
In module BlobEncoder.cpp three similar methods. (BTW may be it's need some refactoring to follow DRY principe& )