Qpid
  1. Qpid
  2. QPID-4422

Python Client (0-8..0-9) should allow "instance" client property to be passed in order to allow re-subscribing to durable subscriptions

    Details

    • Type: Bug Bug
    • Status: Closed
    • Priority: Major Major
    • Resolution: Fixed
    • Affects Version/s: 0.14, 0.16, 0.18
    • Fix Version/s: 0.19
    • Component/s: Python Client
    • Labels:
      None

      Description

      In order reconnect to an exclusive queue, the client must reconnect with the same clientid. In the Python 0-8 and 0-9 client code, this is currently impossible as it does not allow the "instance" client property to be passed to the broker when performing the connection.start, and so the Broker assigns a random one.

      This makes it impossible for the Python client users to use exclusive queues, which are integral to using durable subscriptions properly.

      The 0-10 code does not have this problem.

      The Python client (0-8..0-9 code paths) should be changed to allow the user to pass the client_properties, thus allowing them to specify the instance. We should also take this opportunity to pass the client version number.

        Activity

        Hide
        Keith Wall added a comment -

        Patch applied (work of Phil and myself).

        Show
        Keith Wall added a comment - Patch applied (work of Phil and myself).
        Hide
        Philip Harvey added a comment -

        The changes look functionally good but contain some tabs. These are removed in this patch.

        Show
        Philip Harvey added a comment - The changes look functionally good but contain some tabs. These are removed in this patch.
        Hide
        Philip Harvey added a comment -

        please could you apply the replace-tabs patch

        Show
        Philip Harvey added a comment - please could you apply the replace-tabs patch
        Hide
        Keith Wall added a comment -

        Patch applied.

        Show
        Keith Wall added a comment - Patch applied.

          People

          • Assignee:
            Keith Wall
            Reporter:
            Keith Wall
          • Votes:
            0 Vote for this issue
            Watchers:
            2 Start watching this issue

            Dates

            • Created:
              Updated:
              Resolved:

              Development