Qpid
  1. Qpid
  2. QPID-4415

perl bindings installed in wrong place

    Details

    • Type: Bug Bug
    • Status: Closed
    • Priority: Major Major
    • Resolution: Fixed
    • Affects Version/s: 0.18
    • Fix Version/s: 0.20, 0.21
    • Component/s: None
    • Labels:
      None

      Description

      On Ubuntu 12.04, if I run configure --prefix=/usr the bindings get installed into /usr/usr/lib/perl5...

      However if I run make install from bindings/qpid/perl they get correctly installed.

      On RHEL5 the same issues occurs, but additionally the architecture string is incorrectly put twice into the path /usr/lib/perl/5.14/x86_64-linux-gnu-thread-multi/x86_64-linux-gnu-thread-multi

        Activity

        Hide
        Justin Ross added a comment -

        Reviewed by me. Approved for 0.20.

        Show
        Justin Ross added a comment - Reviewed by me. Approved for 0.20.
        Hide
        Darryl L. Pierce added a comment -
        Show
        Darryl L. Pierce added a comment - Sorry. Here's the link: http://svn.apache.org/viewvc?view=revision&revision=1413693
        Hide
        Justin Ross added a comment -

        Hi, Darryl. Please add a comment with a link to the svn change. I didn't see it in the inclusion request mail.

        Show
        Justin Ross added a comment - Hi, Darryl. Please add a comment with a link to the svn change. I didn't see it in the inclusion request mail.
        Hide
        Darryl L. Pierce added a comment -

        Thank you! I've applied and test this patch. In addition to removing DESTDIR it seems to have fixed the problem, from what I see in my tests.

        Show
        Darryl L. Pierce added a comment - Thank you! I've applied and test this patch. In addition to removing DESTDIR it seems to have fixed the problem, from what I see in my tests.
        Hide
        Jimmy Jones added a comment -

        Fix for perl module being installed in the wrong perl directory (separate to the prefix issue that the existing patch fixes). Tested on RHEL6, Ubuntu 12.04 and modules now installed in correct directory.

        Show
        Jimmy Jones added a comment - Fix for perl module being installed in the wrong perl directory (separate to the prefix issue that the existing patch fixes). Tested on RHEL6, Ubuntu 12.04 and modules now installed in correct directory.
        Hide
        Jimmy Jones added a comment -

        Just tried on RHEL6, and it installs into /usr/lib64/perl5/x86_64-linux-thread-multi/cqpid_perl.pm instead of /usr/lib64/perl5/cqpid_perl.pm

        Show
        Jimmy Jones added a comment - Just tried on RHEL6, and it installs into /usr/lib64/perl5/x86_64-linux-thread-multi/cqpid_perl.pm instead of /usr/lib64/perl5/cqpid_perl.pm
        Hide
        Jimmy Jones added a comment -

        LGTM, thanks.

        Show
        Jimmy Jones added a comment - LGTM, thanks.
        Hide
        Darryl L. Pierce added a comment - - edited

        Testing this on Fedora 17, what I've found is similar. If I configure using "--prefix=/usr", build out of tree and then do "make install DESTDIR=$PWD/temp", I see the Perl bindings being installed to /usr/local/usr/lib64/perl5/... similar to what's reported here.

        I modified the bindings/qpid/Makefile.am as follows:

        @@ -54,7 +54,7 @@ all-local: perl/Makefile

        install-exec-local:
        cd perl ; \

        • $(MAKE) pure_install DESTDIR=$(prefix) ; \
          + $(MAKE) pure_install ; \

        and redid the whole install. Now I see the files that were previously being installed to /usr/local/usr/lib64 properly being installed into the same tree as the rest of Qpid.

        Please test the attached patch and, if it works for you, I'll push it.

        Show
        Darryl L. Pierce added a comment - - edited Testing this on Fedora 17, what I've found is similar. If I configure using "--prefix=/usr", build out of tree and then do "make install DESTDIR=$PWD/temp", I see the Perl bindings being installed to /usr/local/usr/lib64/perl5/... similar to what's reported here. I modified the bindings/qpid/Makefile.am as follows: @@ -54,7 +54,7 @@ all-local: perl/Makefile install-exec-local: cd perl ; \ $(MAKE) pure_install DESTDIR=$(prefix) ; \ + $(MAKE) pure_install ; \ and redid the whole install. Now I see the files that were previously being installed to /usr/local/usr/lib64 properly being installed into the same tree as the rest of Qpid. Please test the attached patch and, if it works for you, I'll push it.

          People

          • Assignee:
            Darryl L. Pierce
            Reporter:
            Jimmy Jones
          • Votes:
            0 Vote for this issue
            Watchers:
            3 Start watching this issue

            Dates

            • Created:
              Updated:
              Resolved:

              Development