[QPID-4398] C++ Broker log statements print address of message rather than message details

• Type: Bug
• Status: Closed
• Priority: Major
• Resolution: Auto Closed
• Affects Version/s: 0.19
• Component/s: C++ Broker
• Assignee: Unassigned
• Reporter: Charles E. Rolke
• Created: 26/Oct/12 13:53
• Updated: 14/Mar/18 20:26
• Resolved: 14/Mar/18 20:26

Description

In file cpp/src/broker/Queue.cpp (and probably elsewhere) log statements print facts about a message using the construct:

Message* msg = xxx;
QPID_LOG(debug, "The message " << msg << " needs logging");

At run time the log statement prints
2012-10-25 19:34:54 [Broker] critical The message 00E596E0 needs logging

I suspect that this is a detail left over from the 0.10-to-1.0 refactoring.

A reasonable message log would contain at least the message headers and possibly some number of message bytes.

Before the recent refactoring the headers could be obtained with:
*(msg->getProperties<MessageProperties>())

Now that same info needs some property accessors.