Qpid
  1. Qpid
  2. QPID-4388

Systemd support not being installed with Cmake

    Details

    • Type: Bug Bug
    • Status: Resolved
    • Priority: Major Major
    • Resolution: Fixed
    • Affects Version/s: 0.19
    • Fix Version/s: 0.21
    • Component/s: None
    • Labels:
      None

      Description

      The enhancement for systemd support was added to the autotools build system but not the Cmake system in QPID-4351.

        Activity

        Hide
        Justin Ross added a comment -

        Andrew, please review.

        Show
        Justin Ross added a comment - Andrew, please review.
        Hide
        Justin Ross added a comment - - edited

        Andrew and I discussed this one, and we don't think this belongs in the set of things installed with cmake. Systemd metadata is not part of any posix or lsb standard; rather, it's currently a feature of just a few linux distros.

        I would personally go further and say that any os integration such as this - unix variant-specific sysvinit scripts or upstart metadata or spec files, etc - belongs somewhere else, either with the distro in question (say, in fedpkg git) or in a qpid contrib module that encapsulates all the os-integration stuff but keeps it isolated from the primary source.

        Show
        Justin Ross added a comment - - edited Andrew and I discussed this one, and we don't think this belongs in the set of things installed with cmake. Systemd metadata is not part of any posix or lsb standard; rather, it's currently a feature of just a few linux distros. I would personally go further and say that any os integration such as this - unix variant-specific sysvinit scripts or upstart metadata or spec files, etc - belongs somewhere else, either with the distro in question (say, in fedpkg git) or in a qpid contrib module that encapsulates all the os-integration stuff but keeps it isolated from the primary source.
        Hide
        Darryl L. Pierce added a comment -

        Fair enough.

        Show
        Darryl L. Pierce added a comment - Fair enough.
        Hide
        Steve Huston added a comment -

        FYI, for Windows this type of thing is in qpid/packaging/windows.

        Show
        Steve Huston added a comment - FYI, for Windows this type of thing is in qpid/packaging/windows.

          People

          • Assignee:
            Andrew Stitcher
            Reporter:
            Darryl L. Pierce
          • Votes:
            0 Vote for this issue
            Watchers:
            3 Start watching this issue

            Dates

            • Created:
              Updated:
              Resolved:

              Development