Qpid
  1. Qpid
  2. QPID-4313

Address review comments from QPID-4109 (Reenable LoggingManagement)

    Details

    • Type: Improvement Improvement
    • Status: Closed
    • Priority: Minor Minor
    • Resolution: Fixed
    • Affects Version/s: 0.19
    • Fix Version/s: 0.19
    • Component/s: Java Broker
    • Labels:
      None

      Description

      Address Alex's review comments made on QPID-4109.

      I omitted to action these comments in time for 0.18. Raising this new Jira as it would be inappropriate to commit further work under old Jira.

        Issue Links

          Activity

          Rob Godfrey made changes -
          Status Resolved [ 5 ] Closed [ 6 ]
          Alex Rudyy made changes -
          Status Ready To Review [ 10006 ] Resolved [ 5 ]
          Resolution Fixed [ 1 ]
          Hide
          Alex Rudyy added a comment -

          The changes looks good for me.
          Reviewed with no commentaries.

          Show
          Alex Rudyy added a comment - The changes looks good for me. Reviewed with no commentaries.
          Keith Wall made changes -
          Assignee Keith Wall [ k-wall ] Alex Rudyy [ alex.rufous ]
          Keith Wall made changes -
          Status In Progress [ 3 ] Ready To Review [ 10006 ]
          Keith Wall made changes -
          Status Open [ 1 ] In Progress [ 3 ]
          Hide
          Keith Wall added a comment -

          Patch applied. Alex, could you review the changes please?

          Show
          Keith Wall added a comment - Patch applied. Alex, could you review the changes please?
          Rob Godfrey made changes -
          Component/s Java Broker [ 12311388 ]
          Keith Wall made changes -
          Priority Major [ 3 ] Minor [ 4 ]
          Keith Wall made changes -
          Link This issue is part of QPID-4109 [ QPID-4109 ]
          Keith Wall made changes -
          Field Original Value New Value
          Issue Type Bug [ 1 ] Improvement [ 4 ]
          Keith Wall created issue -

            People

            • Assignee:
              Alex Rudyy
              Reporter:
              Keith Wall
            • Votes:
              0 Vote for this issue
              Watchers:
              2 Start watching this issue

              Dates

              • Created:
                Updated:
                Resolved:

                Development