Qpid
  1. Qpid
  2. QPID-4311

[Java Distributed Tests] Publishing client publishes messages infinitely if start delay interval exceeds the maximum duration

    Details

    • Type: Bug Bug
    • Status: Resolved
    • Priority: Minor Minor
    • Resolution: Fixed
    • Affects Version/s: 0.19
    • Fix Version/s: 0.19
    • Component/s: Java Performance Tests
    • Labels:
      None

      Description

      Publishing client publishes messages infinitely if start delay interval exceeds the maximum duration

        Activity

        Hide
        Alex Rudyy added a comment -

        Attached patch fixing the issue

        Show
        Alex Rudyy added a comment - Attached patch fixing the issue
        Hide
        Alex Rudyy added a comment -

        Robbie,

        Could you please review and commit the patch attached?

        Show
        Alex Rudyy added a comment - Robbie, Could you please review and commit the patch attached?
        Hide
        Robbie Gemmell added a comment -

        I noticed an issue to do with the producer failing to stop at the right point if you define both time and message limits, and Keith noted the mixture of SLF4J style string formatting and basic string concatination in some of the new logging.

        In the end, I decided to modify the patch so that we throw an exception and fail the test if you misconfigure the test in this way, rather than simply produce no messages, as this makes it more obvious what is wrong than the useless (0 msg) test results will.

        Show
        Robbie Gemmell added a comment - I noticed an issue to do with the producer failing to stop at the right point if you define both time and message limits, and Keith noted the mixture of SLF4J style string formatting and basic string concatination in some of the new logging. In the end, I decided to modify the patch so that we throw an exception and fail the test if you misconfigure the test in this way, rather than simply produce no messages, as this makes it more obvious what is wrong than the useless (0 msg) test results will.

          People

          • Assignee:
            Robbie Gemmell
            Reporter:
            Alex Rudyy
          • Votes:
            0 Vote for this issue
            Watchers:
            2 Start watching this issue

            Dates

            • Created:
              Updated:
              Resolved:

              Development