[QPID-4302] 0-8..0-9-1 client should sync after message.acknowledge()

• Type: Bug
• Status: Closed
• Priority: Major
• Resolution: Fixed
• Affects Version/s: 0.6, 0.8, 0.10, 0.12, 0.14, 0.16, 0.18
• Fix Version/s: 0.19
• Component/s: Broker-J
• Assignee: Robbie Gemmell
• Reporter: Keith Wall
• Created: 13/Sep/12 17:48
• Updated: 11/Feb/15 20:07
• Resolved: 13/Sep/12 20:49

Description

In 0-8..0-9-1 protocols, message acknowledgement (BasicAck) is async by design. There is no BasicAckOk. This presents a problem for JMS CLIENT_ACK mode. When Message#acknowledge() returns the spec requires that the Broker has processed the ack and the client won't see the message(s) again.

Currently calling Message#acknowledge() merely puts the command in buffer to be put on the wire later by the IoSender. There is no assurance that the Broker has even received the command let alone process it successfully.

The client should be changed to sync() once before returning the the client to give assurance that the Broker has received and processed the commands.

For the 0-8..0-9-1 code paths acknowledgement of messages in CLIENT_ACK mode might not happen immediately in Message#acknowledge. It should be updated to acknowledge messages synchronously. There will be a system property to allow the old behaviour to be restored if so desired.

Issue Links

• relates to: QPID-3526 Message#acknowledge() may not acknowledge messages immediately in 0-10 client