Qpid
  1. Qpid
  2. QPID-4272

Large amounts of code are duplicated between the SSL and TCP transports

    Details

    • Type: Improvement Improvement
    • Status: Reopened
    • Priority: Major Major
    • Resolution: Unresolved
    • Affects Version/s: None
    • Fix Version/s: 0.19
    • Component/s: C++ Broker, C++ Client
    • Labels:
      None

      Activity

      Hide
      Andrew Stitcher added a comment -

      With checkins r1401558-r1401561 this is now greatly improved, with the only significant duplication left in the client SslConnector.cpp and TCPConnector.cpp code.

      Show
      Andrew Stitcher added a comment - With checkins r1401558-r1401561 this is now greatly improved, with the only significant duplication left in the client SslConnector.cpp and TCPConnector.cpp code.
      Hide
      Andrew Stitcher added a comment -

      There are only small amounts of duplicated code left

      Show
      Andrew Stitcher added a comment - There are only small amounts of duplicated code left
      Hide
      Pavel Moravec added a comment -

      The duplicate code removal is fine, but it hides error code / description coming from SSL. Originally:

      cpp/src/qpid/sys/ssl/SslIo.cpp:
      QPID_LOG(error, "Error reading socket: " << getErrorString(PR_GetError()));
      

      now:

      cpp/src/qpid/sys/posix/AsynchIO.cpp:
      QPID_LOG(error, "Error reading socket: " << qpid::sys::strError(errno) << "(" << errno << ")" );
      

      That means, most of nicely descripted SSL errors like:

      Error reading socket: SSL peer cannot verify your certificate. [-12271]
      

      are hidden in generous:

      Error reading socket: Success(0)
      

      Could be these SSL errors put back?

      Show
      Pavel Moravec added a comment - The duplicate code removal is fine, but it hides error code / description coming from SSL. Originally: cpp/src/qpid/sys/ssl/SslIo.cpp: QPID_LOG(error, "Error reading socket: " << getErrorString(PR_GetError())); now: cpp/src/qpid/sys/posix/AsynchIO.cpp: QPID_LOG(error, "Error reading socket: " << qpid::sys::strError(errno) << "(" << errno << ")" ); That means, most of nicely descripted SSL errors like: Error reading socket: SSL peer cannot verify your certificate. [-12271] are hidden in generous: Error reading socket: Success(0) Could be these SSL errors put back?

        People

        • Assignee:
          Andrew Stitcher
          Reporter:
          Andrew Stitcher
        • Votes:
          0 Vote for this issue
          Watchers:
          2 Start watching this issue

          Dates

          • Created:
            Updated:

            Development