[QPID-4271] Avoid ThreadLocal leakage etc at shutdown so that Broker behaves better when embedded within Containers

• Type: Bug
• Status: Closed
• Priority: Major
• Resolution: Fixed
• Fix Version/s: 0.19
• Component/s: Broker-J
• Assignee: Robbie Gemmell
• Reporter: Keith Wall
• Created: 30/Aug/12 08:45
• Updated: 11/Feb/15 20:07
• Resolved: 04/Sep/12 16:36

Description

Some customers are embedding the Java Broker within application containers such as Tomcat.

Successive undeploy/redeploy of the component shows warnings highlighting potential ThreadLocal leaks on Container owned threads. For instance, Tomcat reports:

SEVERE: The web application [/qpid-0.19] created a ThreadLocal with key of type [org.apache.qpid.server.logging.actors.CurrentActor$1] (value [org.apache.qpid.server.logging.actors.CurrentActor$1@661eef2c]) and a value of type [java.util.Stack] (value [[]]) but failed to remove it when the web application was stopped. Threads are going to be renewed over time to try and avoid a probable memory leak.
SEVERE: The web application [/qpid-0.19] created a ThreadLocal with key of type [org.apache.qpid.framing.AMQShortString$1] (value [org.apache.qpid.framing.AMQShortString$1@7382ab3e]) and a value of type [org.apache.qpid.framing.AMQShortString$1$1] (value [{queue=queue, ping=ping, test-ping=test-ping, test-queue=test-queue}]) but failed to remove it when the web application was stopped. Threads are going to be renewed over time to try and avoid a probable memory leak.
Aug 28, 2012 4:05:16 PM org.apache.catalina.loader.WebappClassLoader checkThreadLocalMapForLeaks