Qpid
  1. Qpid
  2. QPID-4270

Web management plugin should write operational log entries on startup, shutdown etc

    Details

    • Type: Improvement Improvement
    • Status: Closed
    • Priority: Minor Minor
    • Resolution: Fixed
    • Affects Version/s: None
    • Fix Version/s: 0.19
    • Component/s: Java Broker
    • Labels:
      None

      Description

      Java web management plugin should write operational log messages in a similar fashion to those written by the JMX management plugin. This will allow the user to readily determine that the desired managament layer(s) are operational and to which ports they are bound.

        Activity

        Hide
        Keith Wall added a comment -

        I've changed the web management plugin to log the same operational log messages as the JMX management plugin, with the addition of the new message parameter, which identifies the type of management. The messages look like this:

        [Broker] BRK-1006 : Using configuration : /Users/keith/src/qpid/qpid/java/build/etc/config.xml
        [Broker] BRK-1007 : Using logging configuration : /Users/keith/src/qpid/qpid/java/build/etc/log4j.xml
        [Broker] MNG-1001 : Web Management Startup
        [Broker] MNG-1002 : Starting : HTTP : Listening on port 8080
        [Broker] MNG-1002 : Starting : HTTPS : Listening on port 8443
        [Broker] MNG-1006 : Using SSL Keystore : /Users/keith/src/qpid/qpid/java/build/etc/qpid.keystore
        [Broker] MNG-1004 : Web Management Ready
        [Broker] MNG-1001 : JMX Management Startup
        [Broker] MNG-1002 : Starting : RMI Registry : Listening on port 8999
        [Broker] MNG-1002 : Starting : JMX RMIConnectorServer : Listening on port 9099
        [Broker] MNG-1004 : JMX Management Ready
        [Broker] BRK-1001 : Startup : Version: 0.19 Build: exported
        [Broker] BRK-1010 : Platform : JVM : Apple Inc. version: 1.6.0_33-b03-424-11M3720 OS : Mac OS X version: 10.8 arch: x86_64
        [Broker] BRK-1011 : Maximum Memory : 1,069,416,448 bytes
        [Broker] BRK-1002 : Starting : Listening on TCP port 5672
        [Broker] BRK-1004 : Qpid Broker Ready
        

        and at shutdown:

        012-08-30 21:16:04,213 INFO  [FelixStartLevel] (Log4jMessageLogger.java:73) - [Broker] MNG-1003 : Shutting down : JMX RMIConnectorServer : port 9099
        2012-08-30 21:16:04,214 INFO  [FelixStartLevel] (Log4jMessageLogger.java:73) - [Broker] MNG-1003 : Shutting down : RMI Registry : port 8999
        2012-08-30 21:16:04,216 INFO  [FelixStartLevel] (Log4jMessageLogger.java:73) - [Broker] MNG-1005 : JMX Management Stopped
        2012-08-30 21:16:04,216 INFO  [FelixStartLevel] (Log4jMessageLogger.java:73) - [Broker] MNG-1003 : Shutting down : HTTP : port 8080
        2012-08-30 21:16:04,216 INFO  [FelixStartLevel] (Log4jMessageLogger.java:73) - [Broker] MNG-1003 : Shutting down : HTTPS : port 8443
        2012-08-30 21:16:04,284 INFO  [FelixStartLevel] (Log4jMessageLogger.java:73) - [Broker] MNG-1005 : Web Management Stopped
        2012-08-30 21:16:04,286 INFO  [QpidBrokerShutdownHook] (Log4jMessageLogger.java:73) - [Broker] BRK-1005 : Stopped
        
        Show
        Keith Wall added a comment - I've changed the web management plugin to log the same operational log messages as the JMX management plugin, with the addition of the new message parameter, which identifies the type of management. The messages look like this: [Broker] BRK-1006 : Using configuration : /Users/keith/src/qpid/qpid/java/build/etc/config.xml [Broker] BRK-1007 : Using logging configuration : /Users/keith/src/qpid/qpid/java/build/etc/log4j.xml [Broker] MNG-1001 : Web Management Startup [Broker] MNG-1002 : Starting : HTTP : Listening on port 8080 [Broker] MNG-1002 : Starting : HTTPS : Listening on port 8443 [Broker] MNG-1006 : Using SSL Keystore : /Users/keith/src/qpid/qpid/java/build/etc/qpid.keystore [Broker] MNG-1004 : Web Management Ready [Broker] MNG-1001 : JMX Management Startup [Broker] MNG-1002 : Starting : RMI Registry : Listening on port 8999 [Broker] MNG-1002 : Starting : JMX RMIConnectorServer : Listening on port 9099 [Broker] MNG-1004 : JMX Management Ready [Broker] BRK-1001 : Startup : Version: 0.19 Build: exported [Broker] BRK-1010 : Platform : JVM : Apple Inc. version: 1.6.0_33-b03-424-11M3720 OS : Mac OS X version: 10.8 arch: x86_64 [Broker] BRK-1011 : Maximum Memory : 1,069,416,448 bytes [Broker] BRK-1002 : Starting : Listening on TCP port 5672 [Broker] BRK-1004 : Qpid Broker Ready and at shutdown: 012-08-30 21:16:04,213 INFO [FelixStartLevel] (Log4jMessageLogger.java:73) - [Broker] MNG-1003 : Shutting down : JMX RMIConnectorServer : port 9099 2012-08-30 21:16:04,214 INFO [FelixStartLevel] (Log4jMessageLogger.java:73) - [Broker] MNG-1003 : Shutting down : RMI Registry : port 8999 2012-08-30 21:16:04,216 INFO [FelixStartLevel] (Log4jMessageLogger.java:73) - [Broker] MNG-1005 : JMX Management Stopped 2012-08-30 21:16:04,216 INFO [FelixStartLevel] (Log4jMessageLogger.java:73) - [Broker] MNG-1003 : Shutting down : HTTP : port 8080 2012-08-30 21:16:04,216 INFO [FelixStartLevel] (Log4jMessageLogger.java:73) - [Broker] MNG-1003 : Shutting down : HTTPS : port 8443 2012-08-30 21:16:04,284 INFO [FelixStartLevel] (Log4jMessageLogger.java:73) - [Broker] MNG-1005 : Web Management Stopped 2012-08-30 21:16:04,286 INFO [QpidBrokerShutdownHook] (Log4jMessageLogger.java:73) - [Broker] BRK-1005 : Stopped
        Hide
        Keith Wall added a comment -

        Patch applied. Robbie, could you review please?

        I wish to point out that this change removes the ability of MNG-1004 to log "Using the platform JMX Agent". This was done to allow MNG-1004 to be conveniently shared between the two management implementations (platform JMX Agent makes no sense for Web).

        We also still need to log MNG-1007/MNG-1008, but I thought this was best left until we had the ability to log users out of the console.

        Thoughts welcome.

        Show
        Keith Wall added a comment - Patch applied. Robbie, could you review please? I wish to point out that this change removes the ability of MNG-1004 to log "Using the platform JMX Agent". This was done to allow MNG-1004 to be conveniently shared between the two management implementations (platform JMX Agent makes no sense for Web). We also still need to log MNG-1007 / MNG-1008 , but I thought this was best left until we had the ability to log users out of the console. Thoughts welcome.
        Hide
        Robbie Gemmell added a comment -

        Looks good to me.

        Show
        Robbie Gemmell added a comment - Looks good to me.

          People

          • Assignee:
            Robbie Gemmell
            Reporter:
            Keith Wall
          • Votes:
            0 Vote for this issue
            Watchers:
            2 Start watching this issue

            Dates

            • Created:
              Updated:
              Resolved:

              Development