Qpid
  1. Qpid
  2. QPID-4191

HA removing self address breaks if a VIP is used.

    Details

    • Type: Bug Bug
    • Status: Closed
    • Priority: Major Major
    • Resolution: Fixed
    • Affects Version/s: 0.17
    • Fix Version/s: 0.18
    • Component/s: C++ Clustering
    • Labels:
      None

      Description

      The HA broker was removing its own address from the set of cluster addresses to avoid useless self-connection attempts. However this completely breaks if a Virtual IP address (VIP) is used.

      The remove-self is not essential, self-connection attempts are prevented elsewhere. Backup brokers will be prevented from connecting to self by the same connection-observer as normal clients.

        Activity

        Hide
        Alan Conway added a comment -

        Committed to 0.18 r1370308

        Show
        Alan Conway added a comment - Committed to 0.18 r1370308
        Hide
        Robbie Gemmell added a comment -

        Reviewed by Gordon, approved for 0.18.

        Show
        Robbie Gemmell added a comment - Reviewed by Gordon, approved for 0.18.
        Hide
        Gordon Sim added a comment -

        I have reviewed the change and would support its inclusion in 0.18 due to the severity of the issue it solves and the fact that it is low risk and entirely contained within the HA feature.

        Show
        Gordon Sim added a comment - I have reviewed the change and would support its inclusion in 0.18 due to the severity of the issue it solves and the fact that it is low risk and entirely contained within the HA feature.
        Hide
        Alan Conway added a comment -

        Fix committed to trunk r1370002.
        Request review and 0.18 merge.

        Show
        Alan Conway added a comment - Fix committed to trunk r1370002. Request review and 0.18 merge.

          People

          • Assignee:
            Alan Conway
            Reporter:
            Alan Conway
          • Votes:
            0 Vote for this issue
            Watchers:
            3 Start watching this issue

            Dates

            • Created:
              Updated:
              Resolved:

              Development