Qpid
  1. Qpid
  2. QPID-4187

Management ACL logging sometimes prints N/A instead of user name

    Details

    • Type: Bug Bug
    • Status: Resolved
    • Priority: Minor Minor
    • Resolution: Fixed
    • Affects Version/s: 0.16
    • Fix Version/s: 0.19
    • Component/s: Java Broker
    • Labels:
      None

      Description

      When testing the fix for QPID-4186 we noticed that the "log actor" portion of our management ACL authorization logging sometimes prints N/A where the user name should be.

      For example, this happens if you've connected JConsole using "reconnect" rather than a new connection.

        Issue Links

          Activity

          Hide
          Philip Harvey added a comment -

          The problem is that ManagementActor caches its log message per-thread name.

          When JConsole reconnects the thread name doesn't change so ManagementActor uses its cached log string containing N/A, even though the user name is now available in the thread's Subject.

          Show
          Philip Harvey added a comment - The problem is that ManagementActor caches its log message per-thread name. When JConsole reconnects the thread name doesn't change so ManagementActor uses its cached log string containing N/A, even though the user name is now available in the thread's Subject.
          Hide
          Alex Rudyy added a comment -

          Attached a patch resolving the issue with management logging.

          Phil,please review.

          Show
          Alex Rudyy added a comment - Attached a patch resolving the issue with management logging. Phil,please review.
          Hide
          Alex Rudyy added a comment -

          Robbie,
          Could you please commit the patch?

          Show
          Alex Rudyy added a comment - Robbie, Could you please commit the patch?
          Hide
          Philip Harvey added a comment -

          Reviewed the patch - looks good.

          Show
          Philip Harvey added a comment - Reviewed the patch - looks good.
          Hide
          Robbie Gemmell added a comment -

          Patch applied.

          Show
          Robbie Gemmell added a comment - Patch applied.

            People

            • Assignee:
              Robbie Gemmell
              Reporter:
              Philip Harvey
            • Votes:
              0 Vote for this issue
              Watchers:
              3 Start watching this issue

              Dates

              • Created:
                Updated:
                Resolved:

                Development