Qpid
  1. Qpid
  2. QPID-4182

Define a reasonable default for the 'minimumAlertRepeatGap'

    Details

    • Type: Bug Bug
    • Status: Resolved
    • Priority: Minor Minor
    • Resolution: Fixed
    • Affects Version/s: 0.6, 0.8, 0.10, 0.12, 0.14, 0.16
    • Fix Version/s: 0.18
    • Component/s: Java Broker
    • Labels:
      None

      Description

      Currently the 'minimumAlertRepeatGap' has a default of 0, and relies on config in virtualhosts.xml to actually set a default value. Some users don't have this value (e.g old brokers didnt have the config element, and users copy bits of their config during upgrade), which can result in them getting spammed with excessive multiple alerts (often in the same millisecond). This should be defaulted to a reasonable value (e.g 30sec) in the code.

        Activity

        Hide
        Alex Rudyy added a comment -

        Attached a patch resolving the issue

        Show
        Alex Rudyy added a comment - Attached a patch resolving the issue
        Hide
        Alex Rudyy added a comment -

        Phil,
        Could you please review the patch?

        Show
        Alex Rudyy added a comment - Phil, Could you please review the patch?
        Hide
        Philip Harvey added a comment -

        Reviewed and tested - looks good.

        Robbie - please can you commit?

        Show
        Philip Harvey added a comment - Reviewed and tested - looks good. Robbie - please can you commit?
        Hide
        Robbie Gemmell added a comment -

        Patch applied.

        Show
        Robbie Gemmell added a comment - Patch applied.
        Hide
        Robbie Gemmell added a comment -

        Change merged to the 0.18 branch.

        Show
        Robbie Gemmell added a comment - Change merged to the 0.18 branch.

          People

          • Assignee:
            Robbie Gemmell
            Reporter:
            Alex Rudyy
          • Votes:
            0 Vote for this issue
            Watchers:
            3 Start watching this issue

            Dates

            • Created:
              Updated:
              Resolved:

              Development