Qpid
  1. Qpid
  2. QPID-4174

QMF events for (dis)connecting a client to have few more parameters

    Details

      Description

      I suggest enhancing values populated in 3 events relevant for client (dis)connection:

      clientConnect
      clientConnectFail
      clientDisconnect

      For these events, I suggest adding values:
      remoteParentPid
      remotePid
      remoteProcessName

      That is useful for various reasons:
      1) To have better information who just disconnected or failed to connect (i.e. better monitoring allowing to easily identify the process that is e.g. failing to connect repeatedly)
      2) To allow client processes (listening for the events) to easily know the disconnect event is relevant to itself by comparing its PID with remotePid.

      I am attaching a patch for it.

        Activity

        Pavel Moravec created issue -
        Pavel Moravec made changes -
        Field Original Value New Value
        Attachment 0001_QPID-4174_AllowTCPconn-info.patch [ 12538343 ]
        Pavel Moravec made changes -
        Summary Allow getting information about established TCP connection in Java client QMF events for (dis)connecting a client to have few more parameters
        Description Java client does not offer a method to print out active TCP connection (like string "127.0.0.1:12345->127.0.0.1:5672"). Pure JMS API does not offer so at all, checking sources of Java client shows the underlying TCP socket is kept in a private member of a class that does not offer a (readonly) access to the member.


        The enhancement is meaningful for management purposes to detect connectivity. If the Java client listens for QMF updates from the qpid broker, it get events like "127.0.0.1:12345->127.0.0.1:5672 disconnected". But currently it can not match the event to its local connection(s) as it doesn't know them.

        I am attaching a simple patch file such that AMQConnection class is extended by getSocketString() method.
        I suggest enhancing values populated in 3 events relevant for client (dis)connection:

        clientConnect
        clientConnectFail
        clientDisconnect

        For these events, I suggest adding values:
        remoteParentPid
        remotePid
        remoteProcessName

        That is useful for various reasons:
        1) To have better information who just disconnected or failed to connect (i.e. better monitoring allowing to easily identify the process that is e.g. failing to connect repeatedly)
        2) To allow client processes (listening for the events) to easily know the disconnect event is relevant to itself by comparing its PID with remotePid.

        I am attaching a patch for it.
        Component/s Qpid Managment Framework [ 12312536 ]
        Component/s Java Client [ 12311389 ]
        Pavel Moravec made changes -
        Attachment 0001_QPID-4174_AllowTCPconn-info.patch [ 12538343 ]
        Pavel Moravec made changes -
        Attachment 0001-connect-event-more-QMF-parameters [ 12538893 ]
        Ted Ross made changes -
        Assignee Ted Ross [ tedross ]
        Ken Giusti made changes -
        Assignee Ted Ross [ tedross ] Ken Giusti [ kgiusti ]
        Ken Giusti made changes -
        Status Open [ 1 ] Resolved [ 5 ]
        Fix Version/s 0.19 [ 12322452 ]
        Resolution Fixed [ 1 ]
        Justin Ross made changes -
        Status Resolved [ 5 ] Closed [ 6 ]

          People

          • Assignee:
            Ken Giusti
            Reporter:
            Pavel Moravec
          • Votes:
            0 Vote for this issue
            Watchers:
            3 Start watching this issue

            Dates

            • Created:
              Updated:
              Resolved:

              Development