Qpid
  1. Qpid
  2. QPID-4172

[Java Broker] Virtualhost tasks should reset their thread name upon completion

    Details

    • Type: Bug Bug
    • Status: Closed
    • Priority: Minor Minor
    • Resolution: Fixed
    • Affects Version/s: 0.12, 0.13, 0.14, 0.15, 0.16, 0.17
    • Fix Version/s: 0.18
    • Component/s: Java Broker
    • Labels:
      None

      Description

      Virtualhost tasks should reset their thread name upon completion should reset their thread name upon completion.

      We use a ScheduledThreadPoolExecutor for running Virtualhost level tasks such as TransactionTimeout, VirtualHostHouseKeepingTask, the UpdateTask, etc. These rename the thread at the start of their execution, but do not at the end (as explicitly noted in the code, remove the comment) because it will be reset at the next tasks execution. This can confusingly result in multiple threads with the same name if the pool allocates a task to different threads on subsequent executions, so the tasks should restore the original name when they complete to avoid confusion.

      This will result in the threads always having their generic thread pool name except when executing a given task. It might be useful if we could set the base name for these threads in some way to make them easier to identify, but this may not actually be possible while using a ScheduledThreadPoolExecutor.

        Activity

        Robbie Gemmell created issue -
        Philip Harvey made changes -
        Field Original Value New Value
        Assignee Philip Harvey [ philharveyonline ]
        Philip Harvey made changes -
        Philip Harvey made changes -
        Status Open [ 1 ] In Progress [ 3 ]
        Philip Harvey made changes -
        Status In Progress [ 3 ] Ready To Review [ 10006 ]
        Philip Harvey made changes -
        Assignee Philip Harvey [ philharveyonline ] Alex Rudyy [ alex.rufous ]
        Alex Rudyy made changes -
        Assignee Alex Rudyy [ alex.rufous ] Robbie Gemmell [ gemmellr ]
        Robbie Gemmell made changes -
        Status Ready To Review [ 10006 ] Resolved [ 5 ]
        Resolution Fixed [ 1 ]
        Robbie Gemmell made changes -
        Fix Version/s 0.18 [ 12322451 ]
        Fix Version/s 0.19 [ 12322452 ]
        Affects Version/s 0.18 [ 12322451 ]
        Rob Godfrey made changes -
        Status Resolved [ 5 ] Closed [ 6 ]

          People

          • Assignee:
            Robbie Gemmell
            Reporter:
            Robbie Gemmell
          • Votes:
            0 Vote for this issue
            Watchers:
            3 Start watching this issue

            Dates

            • Created:
              Updated:
              Resolved:

              Development