Qpid
  1. Qpid
  2. QPID-4156

HA close window for clients to connect before HA broker is initialized

    Details

    • Type: Bug Bug
    • Status: Closed
    • Priority: Major Major
    • Resolution: Fixed
    • Affects Version/s: 0.17
    • Fix Version/s: 0.18
    • Component/s: C++ Clustering
    • Labels:
      None

      Description

      A HA backup broker in a cluster rejects client connections. This was previously done in a ConnectionObserver registered during Plugin::initialize. However that left a window before the observer was registered when clients could connect. This showed up as a sporadic failure of the failover test. This patch moves the creation of the observer to Plugin::earlyInitialize, which is guaranteed to be called before the broker starts listening for clients.

        Activity

        Justin Ross made changes -
        Status Resolved [ 5 ] Closed [ 6 ]
        Alan Conway made changes -
        Status In Progress [ 3 ] Resolved [ 5 ]
        Resolution Fixed [ 1 ]
        Hide
        Gordon Sim added a comment -

        Merged on to 0.18 release branch as r1363839.

        Show
        Gordon Sim added a comment - Merged on to 0.18 release branch as r1363839.
        Hide
        Justin Ross added a comment -

        Reviewed by Gordon. Approved for 0.18.

        Show
        Justin Ross added a comment - Reviewed by Gordon. Approved for 0.18.
        Hide
        Gordon Sim added a comment -

        I'm in favour of merging this to the release branch. Since the release candidate has not yet been cut this would seem to have no impact on others. The changes are restricted to the new HA feature. Any glitches like these that we can fix for the 0.18 release will make uptake of this alternative to clustering smoother.

        Show
        Gordon Sim added a comment - I'm in favour of merging this to the release branch. Since the release candidate has not yet been cut this would seem to have no impact on others. The changes are restricted to the new HA feature. Any glitches like these that we can fix for the 0.18 release will make uptake of this alternative to clustering smoother.
        Alan Conway made changes -
        Field Original Value New Value
        Status Open [ 1 ] In Progress [ 3 ]
        Hide
        Alan Conway added a comment -

        Fixed on trunk r1363498

        Request merge to 0.18 branch

        Show
        Alan Conway added a comment - Fixed on trunk r1363498 Request merge to 0.18 branch
        Alan Conway created issue -

          People

          • Assignee:
            Alan Conway
            Reporter:
            Alan Conway
          • Votes:
            0 Vote for this issue
            Watchers:
            3 Start watching this issue

            Dates

            • Created:
              Updated:
              Resolved:

              Development