Qpid
  1. Qpid
  2. QPID-4152

Refactor coverage targets in Java build system

    Details

    • Type: Improvement Improvement
    • Status: Resolved
    • Priority: Minor Minor
    • Resolution: Fixed
    • Affects Version/s: None
    • Fix Version/s: 0.19
    • Component/s: None

      Description

      1) Eliminate a hard-coded list used to determine those modules for which coverage is generated.
      2) Eliminate duplication between the "test" target and the "cover-test" targets.

        Activity

        Hide
        Keith Wall added a comment -

        Hi Phil, can you review this change please?

        Show
        Keith Wall added a comment - Hi Phil, can you review this change please?
        Hide
        Philip Harvey added a comment -

        Attached patch to fix problem running "ant cover-test".

        Added condition to cover-test target so it only runs if units tests exist. Was previously choking trying to run amqp-1-0-common tests, because junit.jar wasn't on classpath.

        Show
        Philip Harvey added a comment - Attached patch to fix problem running "ant cover-test". Added condition to cover-test target so it only runs if units tests exist. Was previously choking trying to run amqp-1-0-common tests, because junit.jar wasn't on classpath.
        Hide
        Philip Harvey added a comment -

        further change is required (see patch). Pls commit it if you're happy with it.

        Show
        Philip Harvey added a comment - further change is required (see patch). Pls commit it if you're happy with it.
        Hide
        Keith Wall added a comment -

        Reviewed, no comments. Patch applied.

        Show
        Keith Wall added a comment - Reviewed, no comments. Patch applied.

          People

          • Assignee:
            Keith Wall
            Reporter:
            Keith Wall
          • Votes:
            0 Vote for this issue
            Watchers:
            2 Start watching this issue

            Dates

            • Created:
              Updated:
              Resolved:

              Development