[QPID-4144] HA broker deadlocks on broeker::QueueRegistry lock and ha::Primary lock

• Type: Bug
• Status: Closed
• Priority: Major
• Resolution: Fixed
• Affects Version/s: 0.17
• Fix Version/s: 0.18
• Component/s: C++ Clustering
• Assignee: Alan Conway
• Reporter: Alan Conway
• Created: 17/Jul/12 17:34
• Updated: 29/Jul/13 18:53
• Resolved: 19/Jul/12 19:20

Description

Running tests repeatedly, the broker deadlocked with the attached stack trace.

The problem call sequences are:
1. QueueRegistry::destroy takes QueuerRegistry lock > ConfigurationObserver::queueDestroy > ha::Primary::queueDestroy takes Primary lock.
2. ConnectionObserver::opened cals Primary::opened lock> RemoteBackup>getQueues().eachQueue

This patch breaks the deadlock at both ends: QueueRegistry no longer holds the lock across the observer call and Primary does not hold the lock across eachQueue.