Uploaded image for project: 'Qpid'
  1. Qpid
  2. QPID-4131

Broker should close connection on transaction timeout rather than close session for better compatibility with Java clients

    Details

    • Type: Bug
    • Status: Closed
    • Priority: Major
    • Resolution: Fixed
    • Affects Version/s: 0.12, 0.14, 0.16
    • Fix Version/s: 0.18, 0.19
    • Component/s: Broker-J
    • Labels:
      None

      Description

      Older versions of the Java Broker (0.5) used to close the connection in the event of transaction time (on detection of open or idle transaction) rather than close the session. When the transaction timeout feature was forward ported to 0.11, the decision was made to close the session for both 0-10 and 0-8...0-9-1. Unfortunately the Java client does not handle the session close correctly and this results in a connection leak.

      This change will revert the 0-8...0-9-1 code paths within the Java Broker to use connection close rather than session close. This will ensure that the Java Broker remains compatibility with Java Clients that suffer this problem..

        Issue Links

          Activity

          Hide
          k-wall Keith Wall added a comment -

          Applied to 0.18 branch.

          Show
          k-wall Keith Wall added a comment - Applied to 0.18 branch.
          Hide
          justi9 Justin Ross added a comment -

          Reviewed by Philip. Approved for 0.18.

          Show
          justi9 Justin Ross added a comment - Reviewed by Philip. Approved for 0.18.
          Hide
          philharveyonline Philip Harvey added a comment -

          Looks good to me. I tested this by repeatedly causing transactions to time out, and used JConsole to observe the corresponding connections disappearing.

          Show
          philharveyonline Philip Harvey added a comment - Looks good to me. I tested this by repeatedly causing transactions to time out, and used JConsole to observe the corresponding connections disappearing.
          Hide
          k-wall Keith Wall added a comment -

          Hi Phil, could you review please?

          Show
          k-wall Keith Wall added a comment - Hi Phil, could you review please?

            People

            • Assignee:
              philharveyonline Philip Harvey
              Reporter:
              k-wall Keith Wall
            • Votes:
              0 Vote for this issue
              Watchers:
              3 Start watching this issue

              Dates

              • Created:
                Updated:
                Resolved:

                Development