Qpid
  1. Qpid
  2. QPID-4124

[Java Broker] TransactionTimeout logging has duplication and some erroneously uses default Object.toString

    Details

    • Type: Bug Bug
    • Status: Closed
    • Priority: Trivial Trivial
    • Resolution: Fixed
    • Affects Version/s: 0.14, 0.15, 0.16, 0.17, 0.18
    • Fix Version/s: 0.19
    • Component/s: Java Broker
    • Labels:
      None

      Description

      In AMQChannel, code such as

      _logger.warn("IDLE TRANSACTION ALERT " + _logSubject.toString() ...

      should be replaced by

      _logger.warn("IDLE TRANSACTION ALERT " + _logSubject.toLogString() ...

      because the first example uses Object.toString, which is not very useful for logging.

        Activity

        Philip Harvey created issue -
        Philip Harvey made changes -
        Field Original Value New Value
        Description Code such as

        _logger.warn("IDLE TRANSACTION ALERT " + _logSubject.toString() ...

        should be replaced by

        _logger.warn("IDLE TRANSACTION ALERT " + _logSubject.toLogString() ...

        because the first example uses Object.toString, which is not very useful for logging.
        In AMQChannel, code such as

        _logger.warn("IDLE TRANSACTION ALERT " + _logSubject.toString() ...

        should be replaced by

        _logger.warn("IDLE TRANSACTION ALERT " + _logSubject.toLogString() ...

        because the first example uses Object.toString, which is not very useful for logging.
        Philip Harvey made changes -
        Status Open [ 1 ] In Progress [ 3 ]
        Philip Harvey made changes -
        Philip Harvey made changes -
        Status In Progress [ 3 ] Ready To Review [ 10006 ]
        Philip Harvey made changes -
        Assignee Philip Harvey [ philharveyonline ] Keith Wall [ k-wall ]
        Philip Harvey made changes -
        Status Ready To Review [ 10006 ] Open [ 1 ]
        Assignee Keith Wall [ k-wall ] Philip Harvey [ philharveyonline ]
        Alex Rudyy made changes -
        Robbie Gemmell made changes -
        Summary AMQChannel checkTransactionStatus logging not useful because it uses default Object.toString TransactionTimout logging has duplication and some erroneously uses default Object.toString
        Robbie Gemmell made changes -
        Summary TransactionTimout logging has duplication and some erroneously uses default Object.toString [Java Broker] TransactionTimout logging has duplication and some erroneously uses default Object.toString
        Fix Version/s 0.19 [ 12322452 ]
        Fix Version/s Future [ 12315490 ]
        Affects Version/s 0.16 [ 12319870 ]
        Affects Version/s 0.15 [ 12319043 ]
        Affects Version/s 0.14 [ 12316855 ]
        Affects Version/s 0.17 [ 12320179 ]
        Robbie Gemmell made changes -
        Status Open [ 1 ] Resolved [ 5 ]
        Resolution Fixed [ 1 ]
        Robbie Gemmell made changes -
        Summary [Java Broker] TransactionTimout logging has duplication and some erroneously uses default Object.toString [Java Broker] TransactionTimeout logging has duplication and some erroneously uses default Object.toString
        Rob Godfrey made changes -
        Status Resolved [ 5 ] Closed [ 6 ]

          People

          • Assignee:
            Philip Harvey
            Reporter:
            Philip Harvey
          • Votes:
            0 Vote for this issue
            Watchers:
            3 Start watching this issue

            Dates

            • Created:
              Updated:
              Resolved:

              Development